Bug 993892 - vym possibly affected by F-20 unversioned docdir change
Summary: vym possibly affected by F-20 unversioned docdir change
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: vym
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL: http://fedoraproject.org/wiki/Changes...
Whiteboard:
Depends On:
Blocks: F20UnversionedDocDirs
TreeView+ depends on / blocked
 
Reported: 2013-08-06 12:57 UTC by Ville Skyttä
Modified: 2013-08-09 15:59 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-09 15:59:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ville Skyttä 2013-08-06 12:57:30 UTC
vym was identified as a package possibly needing maintainer attention
due to the F-20 unversioned doc dir change. The identification is not
foolproof, it is basically this grep:

    grep -E "(/doc|_docdir|_defaultdocdir).+version" *.spec

Please review your package and make the appropriate changes, if any. A
good starting point is checking the lines output by the above grep for
your specfile. For the vast majority of packages, after the changes,
the expected outcome is that documentation dirs in /usr/share/doc
should no longer contain the package version.

More information and tips:
  https://fedoraproject.org/wiki/Changes/UnversionedDocdirs
  http://thread.gmane.org/gmane.linux.redhat.fedora.devel/183942/focus=183943
  http://thread.gmane.org/gmane.linux.redhat.fedora.devel/183942/focus=183973

Comment 1 Gwyn Ciesla 2013-08-08 15:13:30 UTC
False positive.

Comment 2 Ville Skyttä 2013-08-08 20:18:13 UTC
(In reply to Jon Ciesla from comment #1)
> False positive.

Nope, yet again as witnessed by the suggested grep:

$ grep -E "(/doc|_docdir|_defaultdocdir).+version" vym.spec 
qmake-qt4 DOCDIR="%{_docdir}/%{name}-%{version}" PREFIX=%{_prefix}
mv %{buildroot}/usr/share/doc/vym-%{version}/vym.pdf .

DOCDIR ends up compiled in in mainwindow.cpp (through VYM_DOCDIR):

$ grep -rF DOCDIR vym-2.3.19
vym-2.3.19/vym.pro:isEmpty( DOCDIR ) {
vym-2.3.19/vym.pro:    DOCDIR = $${DATADIR}/doc/packages/vym
vym-2.3.19/vym.pro:doc.path = $${DOCDIR}
vym-2.3.19/vym.pro:DEFINES += VYM_DOCDIR=\\\"$${DOCDIR}\\\"
vym-2.3.19/scripts/getbinaries:DOCDIR=$TMPDIR/tex
vym-2.3.19/scripts/getbinaries:cp $DOCDIR/*.pdf $BINDIR
vym-2.3.19/mainwindow.cpp:	#if defined(VYM_DOCDIR)
vym-2.3.19/mainwindow.cpp:	    searchList << VYM_DOCDIR;

Comment 3 Gwyn Ciesla 2013-08-09 15:59:58 UTC
Got it, fixed with conditionals.


Note You need to log in before you can comment on or make changes to this bug.