Bug 996120

Summary:	The bonding params need to be verified and adjusted if needed to prevent serious network degredations
Product:	[Retired] oVirt	Reporter:	Fabian Deutsch <fdeutsch>
Component:	ovirt-node	Assignee:	Fabian Deutsch <fdeutsch>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.2	CC:	acathrow, jboggs, mburns, mgoldboi, ovirt-bugs, ovirt-maint, yeylon
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-node-3.0.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1001468 (view as bug list)		Environment:
Last Closed:	2013-11-28 11:56:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1001468

Description Fabian Deutsch 2013-08-12 12:53:42 UTC

Description of problem:
"""
	It is critical that either the miimon or arp_interval and
arp_ip_target parameters be specified, otherwise serious network
degradation will occur during link failures.  Very few devices do not
support at least miimon, so there is really no reason not to use it.
"""
source: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/bonding.txt#n153

To prevent this case we should check and adjust the arguments if needed during ai and the tui install.
Currently both ways to configure the device don't do any checks on the params and don't even require any params to be set.

Comment 1 Mike Burns 2013-08-15 14:27:28 UTC

IMO (and feel free to argue):

Auto-install:  if the user specifies something for the parameters, then don't change anything.  If they don't pass any parameters, set some sane default.  We generally expect that people know what they're doing with autoinstall

TUI:  when creating a new bond, add default options, but allow the user to change/remove.  If they're editing, don't suddenly add options that weren't there before.

Comment 2 Fabian Deutsch 2013-09-06 11:08:20 UTC

I agree on this position.