Bug 996710
| Summary: | Storage node installer assumes all STDERR messages mean failure | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Elias Ross <genman> | ||||
| Component: | Installer | Assignee: | John Sanda <jsanda> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | ||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | urgent | ||||||
| Version: | 4.8 | CC: | ahovsepy, hrupp | ||||
| Target Milestone: | ER02 | ||||||
| Target Release: | RHQ 4.10 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-04-23 12:29:37 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1006862 | ||||||
| Attachments: |
|
||||||
The installer now only logs a warning when C* writes to stderr. If there is in fact in error, it will be caught during the post-install verification. Some additional checks have been added to the install execution path. The cql, gossip, and jmx ports are checked for conflicts. The installation will fail if there is a conflict for any of those ports. Tests have been added as well. master commit hash: 1ba590c19821 verified in er5 storage install, stop and start having JAVA_TOOL_OPTIONS : -Dfile.encoding=UTF8 has no exception/error in log. see log file attached Created attachment 823479 [details]
java-tool-options-storage.log
Bulk closing of 4.10 issues. If an issue is not solved for you, please open a new BZ (or clone the existing one) with a version designator of 4.10. |
Steps to reproduce: $ export JAVA_TOOL_OPTIONS="-Dfile.encoding=UTF8" ... then run the installer What is seen: 18:36:16,312 ERROR [org.rhq.storage.installer.StorageInstaller] The storage node reported the following errors while trying to start: Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8 18:36:16,312 ERROR [org.rhq.storage.installer.StorageInstaller] Please review your configuration for possible sources of errors such as port conflicts or invalid arguments/options passed to the java executable. The storage node starts correctly, but the installer is blocked. Maybe this should be downgraded to a warning? diff --git a/modules/common/cassandra-installer/src/main/java/org/rhq/storage/installer/StorageInstaller.java b/modules/common/cassandra-insta index 113d66b..cd5b498 100644 --- a/modules/common/cassandra-installer/src/main/java/org/rhq/storage/installer/StorageInstaller.java +++ b/modules/common/cassandra-installer/src/main/java/org/rhq/storage/installer/StorageInstaller.java @@ -438,6 +438,9 @@ public int run(CommandLine cmdLine) throws Exception { log.info("Installation of the storage node is complete"); foundLinkError = true; } + if (startupErrors.contains("JAVA_TOOL_OPTIONS")) { + harmless = true; + } if (!foundLinkError) { log.error("The storage node reported the following errors while trying to start:\n\n" + startupErrors + "\n\n");