Bug 996710 - Storage node installer assumes all STDERR messages mean failure
Summary: Storage node installer assumes all STDERR messages mean failure
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Installer
Version: 4.8
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ER02
: RHQ 4.10
Assignee: John Sanda
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks: jon32-Beta-Blockers-1006862
TreeView+ depends on / blocked
 
Reported: 2013-08-13 18:46 UTC by Elias Ross
Modified: 2014-04-23 12:29 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-04-23 12:29:37 UTC
Embargoed:


Attachments (Terms of Use)
java-tool-options-storage.log (67.53 KB, text/x-log)
2013-11-13 15:26 UTC, Armine Hovsepyan
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1008351 0 urgent CLOSED Storage installer fails on symlinked Java home 2021-02-22 00:41:40 UTC

Internal Links: 1008351

Description Elias Ross 2013-08-13 18:46:14 UTC
Steps to reproduce:

$ export JAVA_TOOL_OPTIONS="-Dfile.encoding=UTF8"
... then run the installer


What is seen:

18:36:16,312 ERROR [org.rhq.storage.installer.StorageInstaller] The storage node reported the following errors while trying to start:

Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8


18:36:16,312 ERROR [org.rhq.storage.installer.StorageInstaller] Please review your configuration for possible sources of errors such as port conflicts or invalid arguments/options passed to the java executable.



The storage node starts correctly, but the installer is blocked. Maybe this should be downgraded to a warning?


diff --git a/modules/common/cassandra-installer/src/main/java/org/rhq/storage/installer/StorageInstaller.java b/modules/common/cassandra-insta
index 113d66b..cd5b498 100644
--- a/modules/common/cassandra-installer/src/main/java/org/rhq/storage/installer/StorageInstaller.java
+++ b/modules/common/cassandra-installer/src/main/java/org/rhq/storage/installer/StorageInstaller.java
@@ -438,6 +438,9 @@ public int run(CommandLine cmdLine) throws Exception {
                         log.info("Installation of the storage node is complete");
                         foundLinkError = true;
                     }
+                    if (startupErrors.contains("JAVA_TOOL_OPTIONS")) {
+                        harmless = true;
+                    }
                     if (!foundLinkError) {
                         log.error("The storage node reported the following errors while trying to start:\n\n"
                             + startupErrors + "\n\n");

Comment 1 John Sanda 2013-09-21 14:57:49 UTC
The installer now only logs a warning when C* writes to stderr. If there is in
fact in error, it will be caught during the post-install verification. Some
additional checks have been added to the install execution path. The cql, gossip, and jmx ports are checked for conflicts. The installation will fail if there is a conflict for any of those ports. Tests have been added as well.

master commit hash: 1ba590c19821

Comment 2 Armine Hovsepyan 2013-11-13 15:25:45 UTC
verified in er5

storage install, stop and start having JAVA_TOOL_OPTIONS : -Dfile.encoding=UTF8 has no exception/error in log.

see log file attached

Comment 3 Armine Hovsepyan 2013-11-13 15:26:23 UTC
Created attachment 823479 [details]
java-tool-options-storage.log

Comment 4 Heiko W. Rupp 2014-04-23 12:29:37 UTC
Bulk closing of 4.10 issues.

If an issue is not solved for you, please open a new BZ (or clone the existing one) with a version designator of 4.10.


Note You need to log in before you can comment on or make changes to this bug.