Bug 998955

Summary:	[origin_ui_66] When user variable name contains non-alphanumeric characters, no warning prompt message output
Product:	OpenShift Online	Reporter:	weiwei jiang <wjiang>
Component:	oc	Assignee:	Fabiano Franz <ffranz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	ffranz, wsun, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-08-29 12:53:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description weiwei jiang 2013-08-20 12:19:28 UTC

Description of problem:
when add variable with its name contains non-alphanumeric characters, it pass without any errors

Version-Release number of selected component (if applicable):
devenv_3678
rhc build from devenv_3677

How reproducible:
always

Steps to Reproduce:
1.Create a app
2.Add a variable via contains non-alphanumeric characters
rhc env set %asdf=adf -a $app_name
rhc env set %2E=asdf -a $app_name
rhc env set @=asdf -a $app_name
rhc env set == -a $app_name
3.Check the variable if it is added 

Actual results:
rhc env set %asdf=adf -a $app_name
Setting environment variable(s) ... 
Unable to complete the requested operation due to: bad URI(is not URI?):
domains/wjiang/applications/appa/environment-variables/%asdf.
Reference ID: 6c112f87f528b9c5abdb34890fb81247
variable is added but can not `rhc env list `

rhc env set %2E=asdf -a $app_name
Setting environment variable(s) ... done
variable is added and can `rhc env list`

rhc env set @=asdf -a $app_name
Setting environment variable(s) ... done
variable is added and can `rhc env list`

rhc env set == -a $app_name
Setting environment variable(s) ... done
variable is not added

Expected results:


Additional info:

Comment 1 Fabiano Franz 2013-08-21 18:03:12 UTC

Pull request: https://github.com/openshift/rhc/pull/444

Comment 2 weiwei jiang 2013-08-22 02:46:47 UTC

Test on devenv_3683, and all display:
Environment variable(s) not provided.
Please provide at least one environment variable using the syntax
VARIABLE=VALUE. VARIABLE can only contain letters, digits and underscore ('_')
and can't begin with a digit.

so verified this, thx

Comment 3 weiwei jiang 2013-08-22 04:27:12 UTC

And rhc version is rhc build from devenv_3683