Spec URL: http://immanetize.fedorapeople.org/python-pyRSS2Gen.spec SRPM URL: http://immanetize.fedorapeople.org/python-pyRSS2Gen-1.1-1.fc21.src.rpm Description: A Python library for generating RSS 2.0 feeds. Fedora Account System Username: immanetize
BuildRequires: python This is insufficient. To call "%{__python} setup.py install" you'll need the Makefile from python2-devel, so add this to BuildRequires. Requires: python is redundant. RPM will find this dependency automatically.
Thanks Mario, I've made the suggested changes. Spec URL: http://immanetize.fedorapeople.org/python-pyRSS2Gen.spec SRPM URL: http://immanetize.fedorapeople.org/python-pyRSS2Gen-1.1-2.fc21.src.rpm Description: A Python library for generating RSS 2.0 feeds. Fedora Account System Username: immanetize
I found some more issues to fix before I give it a try on Koji: Your package is noarch, please add the appropriate tag. README says "Also works under Python 3.x". What about to build also Python3 packages?
I had some trouble testing a python3 build, but this should work: Spec URL: http://immanetize.fedorapeople.org/python-pyRSS2Gen.spec SRPM URL: http://immanetize.fedorapeople.org/python-pyRSS2Gen-1.1-3.fc21.src.rpm Description: A Python library for generating RSS 2.0 feeds. Fedora Account System Username: immanetize
My question: 1. Do you think pyRSS2Gen is the correct name of it? Looking at http://pkgs.org/search/?keyword=pyRSS2Gen, I can find that it has different names in different distros. However, as seen by us in your spec, only URL shows PyRSS2Gen, so my advice is python-PyRSS2Gen, or python-pyrss2gen. 2. http://www.dalkescientific.com/Python/PyRSS2Gen-1.1.tar.gz Please replace 1.1 with version macro, and another suggestion is using pypi as source. 3. I'm not sure it really can play well with py2.7, have you tested it?
1) The module *is* PyRSS2Gen so I've updated the package with a capital "Py" to match. 2) D'oh! fixed. 3) I've tested this within the context of the application I need it for. PyRSS2Gen is a fairly simple set of functions that mostly build on the well-established python-feedparser modules. Can you be more specific about your concern? Spec URL: http://immanetize.fedorapeople.org/python-PyRSS2Gen.spec SRPM URL: http://immanetize.fedorapeople.org/python-PyRSS2Gen-1.1-3.fc21.src.rpm Description: A Python library for generating RSS 2.0 feeds. Fedora Account System Username: immanetize
Scratch build for f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5910309 $ rpmlint -i -v * python-PyRSS2Gen.noarch: I: checking python-PyRSS2Gen.noarch: I: checking-url http://www.dalkescientific.com/Python/PyRSS2Gen.html (timeout 10 seconds) python-PyRSS2Gen.src: I: checking python-PyRSS2Gen.src: I: checking-url http://www.dalkescientific.com/Python/PyRSS2Gen.html (timeout 10 seconds) python-PyRSS2Gen.src: I: checking-url http://www.dalkescientific.com/Python/PyRSS2Gen-1.1.tar.gz (timeout 10 seconds) python-PyRSS2Gen.spec: I: checking-url http://www.dalkescientific.com/Python/PyRSS2Gen-1.1.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 0 warnings. No issues so far. But the python3 package won't be build. The lines "%if 0%{?with_python3}" doesn't do anything as long as this condition is not defined. Just add the line "%global with_python3 1" on top of the spec file and you get both py2 and py3 versions.
Thanks Mario, that got me testing with python3. This release should work for both python and the python3 subpackage. Spec URL: http://immanetize.fedorapeople.org/python-PyRSS2Gen.spec SRPM URL: http://immanetize.fedorapeople.org/python-PyRSS2Gen-1.1-4.fc21.src.rpm Description: A Python library for generating RSS 2.0 feeds. Fedora Account System Username: immanetize
Still no "%global with_python3 1".
*facepalm* I thought that was just for testing purposes, but checked a few other packages. Fixed now.
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5929179 $ koji build --scratch f20 *.src.rpm Uploading srpm: python-PyRSS2Gen-1.1-4.fc21.src.rpm [====================================] 100% 00:00:06 12.11 KiB 1.79 KiB/sec Created task: 5929179 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5929179 Watching tasks (this may be safely interrupted)... 5929179 build (f20, python-PyRSS2Gen-1.1-4.fc21.src.rpm): open (arm02-builder05.arm.fedoraproject.org) 5929180 buildArch (python-PyRSS2Gen-1.1-4.fc21.src.rpm, noarch): open (buildvm-24.phx2.fedoraproject.org) 5929180 buildArch (python-PyRSS2Gen-1.1-4.fc21.src.rpm, noarch): open (buildvm-24.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 5929179 build (f20, python-PyRSS2Gen-1.1-4.fc21.src.rpm): open (arm02-builder05.arm.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 5929179 build (f20, python-PyRSS2Gen-1.1-4.fc21.src.rpm) completed successfully [mariobl@localhost python-pyRSS2Gen]$ rpmlint -i -v * python3-PyRSS2Gen.noarch: I: checking python3-PyRSS2Gen.noarch: I: checking-url http://www.dalkescientific.com/Python/PyRSS2Gen.html (timeout 10 seconds) python-PyRSS2Gen.noarch: I: checking python-PyRSS2Gen.noarch: I: checking-url http://www.dalkescientific.com/Python/PyRSS2Gen.html (timeout 10 seconds) python-PyRSS2Gen.src: I: checking python-PyRSS2Gen.src: I: checking-url http://www.dalkescientific.com/Python/PyRSS2Gen.html (timeout 10 seconds) python-PyRSS2Gen.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 2) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. python-PyRSS2Gen.src: I: checking-url http://www.dalkescientific.com/Python/PyRSS2Gen-1.1.tar.gz (timeout 10 seconds) python-PyRSS2Gen.spec:12: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 2) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. python-PyRSS2Gen.spec: I: checking-url http://www.dalkescientific.com/Python/PyRSS2Gen-1.1.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 2 warnings. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. BSD [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum * 2a9a3ee7c8e30cb40434ef3a295f9a60166f7d8c3eaefac9f46f7ed4b27c2269 PyRSS2Gen-1.1.tar.gz 2a9a3ee7c8e30cb40434ef3a295f9a60166f7d8c3eaefac9f46f7ed4b27c2269 PyRSS2Gen-1.1.tar.gz.orig [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [.] MUST: Development files must be in a -devel package. [.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses Mock anyway). [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. ---------------- PACKAGE APPROVED ---------------- Your package is OK so far; there remains the (rather cosmetic) warning about mixing spaces and tabs. I approve it for the time being, but I trust that you'll change it before importing into the Git repo.
New Package SCM Request ======================= Package Name: python-PyRSS2Gen Short Description: A Python library for generating RSS 2.0 feeds Owners: immanetize Branches: f18 f19 f20 InitialCC:
Git done (by process-git-requests).
python-PyRSS2Gen-1.1-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-PyRSS2Gen-1.1-4.fc20
python-PyRSS2Gen-1.1-4.fc20 has been pushed to the Fedora 20 testing repository.
f20 is unfreezed now.
I think that you can push it to stable now.
python-PyRSS2Gen-1.1-4.fc20 has been pushed to the Fedora 20 stable repository.