Spec URL: http://miroslav.suchy.cz/fedora/rubygem-single_test/rubygem-single_test.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-single_test/rubygem-single_test-0.6.0-1.fc19.src.rpm Description: Runs a single test/spec via rake. Fedora Account System Username: msuchy Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5844696
Just quick note: spec file does not contain %check section, because tests use bundler and therefore are not so much useful for us.
Taking. I will appreciate it if you would review one of my review requests (e.g. bug 912960 )
Some initial comments: * Software Collection macros - I don't know well about the current status of SCL, however it you want to add SCL macros, please follow https://fedoraproject.org/wiki/Packaging:Guidelines#Software_Collection_Macros (especially the sentence beginning whth "Packages who choose....") ? Unknown macros - Would you explain how %git_hash macro is used? (Also see below) * Licensing - The following page https://raw.github.com/grosser/single_test/master/Readme.md says this is under MIT. At least please include the above license text in the binary rpm and modify License tag. * Using %gem_install - %gem_install is available on Fedora 18 and above (so you can change to %if 0%{?fedora} >= 18 ) * %check - > Just quick note: spec file does not contain %check section, > because tests use bundler and therefore are not so much useful for us. Well, so would you explain why "BR: rubygem-rspec" exists? (By the way. please use rubygem(rspec) instead of rubygem-rspec) Note that git source https://github.com/grosser/single_test.git contains spec/ directory and it seems you can do some tests via $ rspec spec/ using git source. It is recommended that you package test files under spec/ directory from git source and add %check section, do some tests there (or still bundler is needed for rspec test suite?)
Additional commens * rpmlint - Please fix below rubygem-single_test.noarch: E: script-without-shebang /usr/share/gems/gems/single_test-0.6.0/lib/single_test/tasks.rb
> * Software Collection macros added that comment > %git_hash macro This was left over (see below). Removed. > * Licensing Good catch. I missed this. Fixed. I however decided to not include separate license file as I am not sure what to put in first line of MIT-LICENSE. Filed: https://github.com/grosser/single_test/issues/12 > * Using %gem_install Fixed. > * %check Well I tried to package that git archive and include it as SOURCE1 (from this try-and-error comes that %git_hash macro where I stored git hash from which I made tar.gz). I tried to run rspec spec/ But what cause problems is: bundle exec rspec And I'm not really sure if seding it to s/bundle exec rspec/rspec/ is correct way. I would rather avoid that as the semantics can be different. > * rpmlint Fixed
Updated: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-single_test/rubygem-single_test.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-single_test/rubygem-single_test-0.6.0-2.fc19.src.rpm
Is http://miroslav.suchy.cz/ alive?
Well, (In reply to Miroslav Suchý from comment #5) > > * Licensing > Good catch. I missed this. Fixed. I however decided to not include separate > license file as I am not sure what to put in first line of MIT-LICENSE. - What I meant here is that at least you should include "README.md" which declares that this is under MIT (MIT license has some variants so it is actually unsure what "MIT" license to put in, however as long as README.md says "this is MIT", we can trust it)
BTW now it seems http://miroslav.suchy.cz/ is alive.
> Is http://miroslav.suchy.cz/ alive I have short outage of my personal web server. You was just lucky to hit it :) > > * Licensing OK. It is not included directly in gem file, so I added it as second and third source (together with LICENSE which Michael promptly committed to git. Updated: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-single_test/rubygem-single_test.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-single_test/rubygem-single_test-0.6.0-3.fc19.src.rpm
For -3: * Place for documentation - Well, as usually gem installs document files under %gem_instdir, perhaps it is better that MIT-LICENSE and README.md be put under %gem_instdir, not under %_defaultdocdir/%name{-%version} .
I prefer to have them in pkgdocdir. See my recent proposal. https://lists.fedoraproject.org/pipermail/ruby-sig/2013-August/001418.html I put symlink into gem_instdir Spec URL: http://miroslav.suchy.cz/fedora/rubygem-single_test/rubygem-single_test.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-single_test/rubygem-single_test-0.6.0-5.fc19.src.rpm
Approving. ----------------------------------------------------------------- This package (rubygem-single_test) is APPROVED by mtasaka ------------------------------------------------------------------
Thank you.
New Package SCM Request ======================= Package Name: rubygem-single_test Short Description: Rake tasks to invoke single tests/specs with rakish syntax Owners: msuchy Branches: f19 f20 InitialCC:
Git done (by process-git-requests).
rubygem-single_test-0.6.0-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-single_test-0.6.0-5.fc19
rubygem-single_test-0.6.0-5.fc19 has been pushed to the Fedora 19 testing repository.
rubygem-single_test-0.6.0-5.fc19 has been pushed to the Fedora 19 stable repository.