Bug 1000361 - Review Request: geocode-glib - Geocoding helper library
Review Request: geocode-glib - Geocoding helper library
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Elad Alfassa
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-23 05:35 EDT by Kalev Lember
Modified: 2013-08-23 11:08 EDT (History)
3 users (show)

See Also:
Fixed In Version: geocode-glib-0.99.2-1.fc20
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-08-23 11:08:12 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
elad: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Kalev Lember 2013-08-23 05:35:29 EDT
Spec URL: http://kalev.fedorapeople.org/geocode-glib.spec
SRPM URL: http://kalev.fedorapeople.org/geocode-glib-0.99.2-1.fc20.src.rpm
Description:
geocode-glib is a convenience library for the geocoding (finding longitude,
and latitude from an address) and reverse geocoding (finding an address from
coordinates). It uses Nominatim service to achieve that. It also caches
(reverse-)geocoding requests for faster results and to avoid unnecessary server
load.

Fedora Account System Username: kalev
Comment 1 Elad Alfassa 2013-08-23 05:40:46 EDT
I'll do the review
Comment 2 Elad Alfassa 2013-08-23 06:17:18 EDT
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 3
     files have unknown license. Detailed output of licensecheck in
     /home/elad/1000361-geocode-glib/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 40960 bytes in 4 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
     Note: geocode-glib : /usr/lib64/pkgconfig/geocode-glib-1.0.pc
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: geocode-glib-0.99.2-1.fc19.x86_64.rpm
          geocode-glib-devel-0.99.2-1.fc19.x86_64.rpm
geocode-glib.x86_64: W: spelling-error Summary(en_US) Geocoding -> Geo coding, Geo-coding, Codding
geocode-glib.x86_64: W: spelling-error %description -l en_US geocoding -> codding
geocode-glib.x86_64: E: incorrect-fsf-address /usr/share/doc/geocode-glib-0.99.2/COPYING.LIB
geocode-glib.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/geocode-glib-1.0.pc
2 packages and 0 specfiles checked; 1 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint geocode-glib-devel geocode-glib
geocode-glib.x86_64: W: spelling-error Summary(en_US) Geocoding -> Geo coding, Geo-coding, Codding
geocode-glib.x86_64: W: spelling-error %description -l en_US geocoding -> codding
geocode-glib.x86_64: E: incorrect-fsf-address /usr/share/doc/geocode-glib-0.99.2/COPYING.LIB
geocode-glib.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/geocode-glib-1.0.pc
2 packages and 0 specfiles checked; 1 errors, 3 warnings.
# echo 'rpmlint-done:'



Requires
--------
geocode-glib-devel (rpmlib, GLIBC filtered):
    geocode-glib(x86-64)
    libgeocode-glib.so.0()(64bit)

geocode-glib (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    /usr/bin/pkg-config
    libc.so.6()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libjson-glib-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    libsoup-2.4.so.1()(64bit)
    pkgconfig(gio-2.0)
    rtld(GNU_HASH)



Provides
--------
geocode-glib-devel:
    geocode-glib-devel
    geocode-glib-devel(x86-64)

geocode-glib:
    geocode-glib
    geocode-glib(x86-64)
    libgeocode-glib.so.0()(64bit)
    pkgconfig(geocode-glib-1.0)



Source checksums
----------------
http://download.gnome.org/sources/geocode-glib/0.99/geocode-glib-0.99.2.tar.xz :
  CHECKSUM(SHA256) this package     : ac4c388603f4c1796df0e9207995b04d35c2116ee99b9f5e173a73eac64abd02
  CHECKSUM(SHA256) upstream package : ac4c388603f4c1796df0e9207995b04d35c2116ee99b9f5e173a73eac64abd02


Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-19-x86_64
Command line :/usr/bin/fedora-review -b 1000361





=====ISSUES====
Only one problem found, there seem to be some GPL files in the package. Please change the license tag accordingly. Other than that - all good
Comment 3 Kalev Lember 2013-08-23 06:42:56 EDT
Thanks Elad!

All the source code seems to LGPL though, where did you see the GPL files? Are you talking about ltmain.sh ?

In that case it is just a tool used for building the library and doesn't get included in the binary package. The License: tag is for _binary_ packages so even though there's a GPL tool used for building it, as long as it doesn't end up in the binary package it doesn't affect its License: tag.
Comment 4 Elad Alfassa 2013-08-23 06:50:07 EDT
fedora-review seems to have found a GPL'd file. Further examination confirms that you are indeed correct, and I should have looked more closely.

Package APPROVED
Comment 5 Kalev Lember 2013-08-23 07:00:46 EDT
Thanks Elad!

New Package SCM Request
=======================
Package Name: geocode-glib
Short Description: Geocoding helper library
Owners: zeenix hadess kalev
Branches: f20
InitialCC:
Comment 6 Gwyn Ciesla 2013-08-23 08:42:02 EDT
Git done (by process-git-requests).
Comment 7 Kalev Lember 2013-08-23 11:08:12 EDT
Package imported and built; closing the ticket.

Note You need to log in before you can comment on or make changes to this bug.