Bug 1000862 - Review Request: emacs-mallard-mode - Emacs major mode for editing Mallard pages
Review Request: emacs-mallard-mode - Emacs major mode for editing Mallard pages
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Eduardo Echeverria
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-25 21:47 EDT by Jaromir Hradilek
Modified: 2014-08-09 04:39 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
echevemaster: fedora‑review?


Attachments (Terms of Use)

  None (edit)
Description Jaromir Hradilek 2013-08-25 21:47:20 EDT
Spec URL: http://jhradile.fedorapeople.org/packages/emacs-mallard-mode/emacs-mallard-mode.spec
SRPM URL: http://jhradile.fedorapeople.org/packages/emacs-mallard-mode/emacs-mallard-mode-0.3.0-1.fc19.src.rpm
Description: The emacs-mallard-mode package provides Mallard mode, a major mode for editing Mallard pages in GNU Emacs. When enabled, this mode automatically loads the RELAX NG schema for the Mallard language, sets appropriate indentation rules, and enables automatic line wrapping. In addition, it provides a number of commands and key bindings that integrate it with the yelp-check utility in order to provide maximum comfort when working on Mallard files.
Fedora Account System Username: jhradile
Successfull Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5852508

Mallard is an XML-based markup language for topic-based documentation that is extensively used by the GNOME Project. This is my very first attempt to crate a Fedora package, so any advice is most welcome. Also, if there is anything I can do as the upstream maintainer to make it easier to package this piece of software for Fedora, please, let me know and I will do my best. Note that the spec file is based on a sample file that was kindly sent to me by Paul W. Frields.

I am currently in need of a sponsor. In the future, I would also like to take over the maintenance of blazeblogger, another creation of mine which no longer seems to be maintained in Fedora 19: http://koji.fedoraproject.org/koji/packageinfo?packageID=9006
Comment 1 Christopher Meng 2013-08-25 21:50:58 EDT
- If there is no such

%clean

%post

%preun

sections, just remove them.

- Use install instead of %{__install}

- You can use %setup -q in %prep, default---> %setup -q -n %{name}-%{version}
Comment 2 Jaromir Hradilek 2013-08-25 22:12:01 EDT
Thank you very much, Christopher. I have updated both the spec file and the SRPM package according to your advice.
Comment 3 Eduardo Echeverria 2014-08-09 04:39:59 EDT
Hi jaromir, some comments to your spec:

- Manage the sourc urle following this guideline http://fedoraproject.org/wiki/Packaging:SourceURL#Github

- According to the emacs guidelines since Fedora 16 the elisp files  not should be splitted in subpackages

See http://fedoraproject.org/wiki/Packaging:Emacs

Note You need to log in before you can comment on or make changes to this bug.