Spec URL: http://thozza.fedorapeople.org/hyperv-daemons/hyperv-daemons.spec SRPM URL: http://thozza.fedorapeople.org/hyperv-daemons/hyperv-daemons-0-0.1.20130826git.fc19.src.rpm Description: Suite of daemons that are needed when Linux guest is running on Windows Host with HyperV. Fedora Account System Username: thozza
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5853731
No need to keep %defattr(-,root,root,-) and %clean section in 2013 ;)
(In reply to Christopher Meng from comment #2) > No need to keep %defattr(-,root,root,-) and %clean section in 2013 ;) Removed...
Hi, the only minor issues I've found is that you define BuildRoot yourself and clean it in %install, which are not needed anymore. Otherwise the package in a good shape. Because the above mentioned issues are not a must I consider this package APPROVED ! ------------------------------------------------------------------- Here follows the formal review: Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package ... [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source. [x]: Spec file name must match the spec package %{name}. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Buildroot is not present [x]: Final provides and requires are sane. [-]: Fully versioned dependency in subpackages if applicable. Note: Not needed as HyperV is available only on x86 architectures [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Package has no %clean section with rm -rf %{buildroot} [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
(In reply to Jiri Popelka from comment #4) > Hi, the only minor issues I've found is that you define BuildRoot yourself > and clean it in %install, which are not needed anymore. Otherwise the > package in a good shape. > > Because the above mentioned issues are not a must I consider this package > APPROVED ! Thanks a lot for the review Jirka!
New Package SCM Request ======================= Package Name: hyperv-daemons Short Description: Suite of daemons that are needed when Linux guest is running on Windows Host with HyperV. Owners: thozza Branches: f18 f19 f20 InitialCC:
Git done (by process-git-requests).
hyperv-daemons-0-0.1.20130826git.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/hyperv-daemons-0-0.1.20130826git.fc18
hyperv-daemons-0-0.1.20130826git.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/hyperv-daemons-0-0.1.20130826git.fc19
hyperv-daemons-0-0.1.20130826git.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/hyperv-daemons-0-0.1.20130826git.fc20
hyperv-daemons-0-0.1.20130826git.fc20 has been pushed to the Fedora 20 testing repository.
hyperv-daemons-0-0.1.20130826git.fc18 has been pushed to the Fedora 18 stable repository.
hyperv-daemons-0-0.1.20130826git.fc19 has been pushed to the Fedora 19 stable repository.
hyperv-daemons-0-0.2.20130826git.fc20 has been pushed to the Fedora 20 stable repository.