Bug 1001546 - [de_DE, es_ES][RHEVM3.3][Admin Portal] - Indentation error found on New Network QoS page under Data Center Tab
Summary: [de_DE, es_ES][RHEVM3.3][Admin Portal] - Indentation error found on New Netwo...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.3.0
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
: 3.3.0
Assignee: Gilad Chaplik
QA Contact: Yuko Katabami
URL:
Whiteboard: i18n
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-27 09:13 UTC by Satyabrata Maitra
Modified: 2016-02-10 19:00 UTC (History)
13 users (show)

Fixed In Version: is17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: i18n
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screen-shot: NewNetworkQoS - Locales Comparison (40.98 KB, image/png)
2013-09-06 16:52 UTC, Einav Cohen
no flags Details
NewNetworkQoS - Improvement Suggestion (42.29 KB, image/png)
2013-09-06 16:53 UTC, Einav Cohen
no flags Details
NewNetworkQoS - Improvement Suggestion 2 (23.25 KB, image/png)
2013-09-06 16:54 UTC, Einav Cohen
no flags Details
Fixed New Network QoS (23.11 KB, image/png)
2013-10-11 08:25 UTC, Lijun Li
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 19356 0 None None None Never
oVirt gerrit 19642 0 None None None Never

Description Satyabrata Maitra 2013-08-27 09:13:54 UTC
Description of problem:
There are some indentation error found in Admin Portal --> Data Center --> Network QoS --> New.
It generally happens due to long translation strings and fixed size of the levels, buttons properties. For the first case, its a translation error, otherwise, its an i18n error and needs to be fixed in the design level by devel.

Version-Release number of selected component (if applicable):
Red Hat Enterprise Virtualisationsmanager Version: 3.3.0-0.16.master.el6ev

How reproducible:
Always

Steps to Reproduce:
1. Login with correct login credentials in RHEVM Admin Portal with de_DE locale
2. Go to Data Center --> Network QoS tab
3. Click on New
4. Observe the Indentation of Inbound and Outbound heads and its values.

Actual results:
Indentation error happening due to translation or design error

Expected results:
There should be no indentation problem.

Additional info:
Screen shot attached with red arrow marks towards the errors.

Comment 1 Doron Fediuck 2013-08-28 14:24:24 UTC
(In reply to Satyabrata Maitra from comment #0)
> 
> Additional info:
> Screen shot attached with red arrow marks towards the errors.

Attachment is missing. Can you please provide it?

Comment 2 Satyabrata Maitra 2013-08-30 03:43:16 UTC
Created attachment 791994 [details]
de_DE error in new network QoS page Admin portal

Same happening for es_ES as well.

Comment 3 Einav Cohen 2013-09-06 16:52:42 UTC
Created attachment 794888 [details]
screen-shot: NewNetworkQoS - Locales Comparison

Comment 4 Einav Cohen 2013-09-06 16:53:47 UTC
Created attachment 794889 [details]
NewNetworkQoS - Improvement Suggestion

Comment 5 Einav Cohen 2013-09-06 16:54:15 UTC
Created attachment 794890 [details]
NewNetworkQoS - Improvement Suggestion 2

Comment 6 Einav Cohen 2013-09-06 17:06:34 UTC
see attachment 794888 [details] - it seems that the indentation behavior is pretty-much consistent across all locales, including English. 

the only problem that I see in the non-English locales is an horizontal scroll-bar that appears at the bottom of the dialog.

I suggest to do one of the following:

(a) extend the dialog width to accommodate longer strings without having a horizontal scroll-bar.

(b) change the layout of the dialog according to one of the attached suggestions:

  (1) attachment 794889 [details] (a better alignment of the visual components will reduce the horizontal real-estate that the current content is occupying).

  (2) attachment 794890 [details] (more of a "classic" components arrangement, which might take a little more vertical real-estate, but will eliminate / reduce layout problems such as the current one to minimum).

Comment 7 Eldan Hildesheim 2013-09-17 14:30:49 UTC
Option 1 is better to serve as a widget.
It's compact and can be implemented graphically in a nice way.
There could be a small problem of language translation (width of the words: average, peak burst) but it won't be terrible.

Option 2 layout is better in point of view of translation (long words)
But it will be worst to serve as a widget in another dialogue cause it's too long.

My opinion: option 1

Comment 8 Lijun Li 2013-10-11 08:22:42 UTC
Verified it's fixed on is18 build: rhevm-3.3.0-0.25.beta1.el6ev.noarch.rpm

Please see the attached screenshot.

Comment 9 Lijun Li 2013-10-11 08:25:01 UTC
Created attachment 810913 [details]
Fixed New Network QoS

Comment 10 Itamar Heim 2014-01-21 22:29:43 UTC
Closing - RHEV 3.3 Released

Comment 11 Itamar Heim 2014-01-21 22:29:43 UTC
Closing - RHEV 3.3 Released

Comment 12 Itamar Heim 2014-01-21 22:32:43 UTC
Closing - RHEV 3.3 Released

Comment 13 Dave Wysochanski 2015-02-11 22:23:02 UTC
Created attachment 990670 [details]
Simple test case for this bug

Comment 14 Dave Wysochanski 2015-02-11 22:24:41 UTC
Created attachment 990671 [details]
test rpm with patch V3 patch from Ben in https://bugzilla.redhat.com/attachment.cgi?id=981565


Note You need to log in before you can comment on or make changes to this bug.