Bug 1001569 - Review Request: python-openopt - A python module for numerical optimization
Summary: Review Request: python-openopt - A python module for numerical optimization
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-27 10:11 UTC by Steve Traylen
Modified: 2014-09-12 11:59 UTC (History)
3 users (show)

Fixed In Version: python-openopt-0.5092-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-05 01:27:52 UTC
Type: ---
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Steve Traylen 2013-08-27 10:11:14 UTC
Spec URL: http://cern.ch/straylen/rpms/python-openopt/python-openopt.spec
SRPM URL: http://cern.ch/straylen/rpms/python-openopt/
Description: A python module for numerical optimization
Fedora Account System Username: stevetraylen

rpmlint is clean
koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=5859080

I plan to release for EPEL 6 as well once #1001562

is resolved.

Comment 2 Christopher Meng 2013-08-27 10:37:31 UTC
APPROVED.

Comment 3 Christopher Meng 2013-08-27 10:38:54 UTC
I'd like to maintain a Fedora branch of it, can you add this branch? Then you orphan it to me.

Comment 4 Steve Traylen 2013-08-27 10:54:24 UTC
Hi Chris,
 Yes I'm doing the fedora branch as well anyway.

Comment 5 Steve Traylen 2013-08-27 10:56:56 UTC
New Package SCM Request
=======================
Package Name: python-openopt
Short Description: A python module for numerical optimization
Owners: stevetraylen
Branches: f20 f19 el6

Comment 6 Gwyn Ciesla 2013-08-27 12:24:48 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-08-27 13:38:59 UTC
python-openopt-0.5092-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-openopt-0.5092-1.el6

Comment 8 Fedora Update System 2013-08-27 13:41:33 UTC
python-openopt-0.5092-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-openopt-0.5092-1.fc19

Comment 9 Ralf Corsepius 2013-08-27 15:37:25 UTC
Folks, 37 minutes from submission to approval and 2-3 hours to git import!

Are you serious or just working carelessly? As it's impossible to perform a careful review in this time, I am guessing on the former.


I think FESCO should intervene and stop this practice - It's grossly careless!!

Christopher, I am seriously concerned about your "reviews", because the quality of your submissions and postings makes it very clear you are lacking experience and probably are not able to understand what you are doing.

Comment 10 Christopher Meng 2013-08-27 15:53:32 UTC
(In reply to Ralf Corsepius from comment #9)
> Folks, 37 minutes from submission to approval and 2-3 hours to git import!
> 
> Are you serious or just working carelessly? As it's impossible to perform a
> careful review in this time, I am guessing on the former.
> 
> 
> I think FESCO should intervene and stop this practice - It's grossly
> careless!!
> 
> Christopher, I am seriously concerned about your "reviews", because the
> quality of your submissions and postings makes it very clear you are lacking
> experience and probably are not able to understand what you are doing.

Hi Ralf,

I can't find any errors even warnings from rpmlint.

I don't have habit to paste rpmlint everytime, but I will run fedora-review instead.

The linpack package, in fact, I don't want to take. Bjorn asked me if I can take on gtalk.  I'll prevent such reviews from now on.

For this one, what's your problem?

You mean we need to wait months just for a python module?

Comment 11 Fedora Update System 2013-08-27 17:07:48 UTC
python-openopt-0.5092-1.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 12 Ralf Corsepius 2013-08-28 04:53:22 UTC
(In reply to Christopher Meng from comment #10)

> I can't find any errors even warnings from rpmlint.
rpmlint is just a hinting tool and so is fedora-review.

Them "not complaining" rsp. "complaining", doesn't mean much. These tools are just imperfect tools, whose results often contain bogus warnings and don't catch issue. These tools' results should not be taken to be more than hints.

They are not a replacement for visual inspection and further manual checks. If they were, we could close down the review process and rely on them - This is not the case.

 
> For this one, what's your problem?
I am accusing you of working overly hasty and to probably not having comprehended the breadth of a review.
 
> You mean we need to wait months just for a python module?
No. I am asking you to work more carefully. This also means not to rush through reviews, such that others have a chance to also have an eye on a package.

As to err is human, nobody is perfect, so they might see something, which had escaped you.

Comment 13 Fedora Update System 2013-09-05 01:27:52 UTC
python-openopt-0.5092-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2013-09-11 18:09:52 UTC
python-openopt-0.5092-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 15 Steve Traylen 2014-09-12 08:41:02 UTC
Package Change Request
======================
Package Name: python-openopt
New Branches: epel7
Owners: stevetraylen

Comment 16 Gwyn Ciesla 2014-09-12 11:59:33 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.