RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1001645 - harfbuzz: misuse of snprintf return value
Summary: harfbuzz: misuse of snprintf return value
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: harfbuzz
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Parag Nemade
QA Contact: QE Internationalization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 1001533
TreeView+ depends on / blocked
 
Reported: 2013-08-27 12:59 UTC by Florian Weimer
Modified: 2014-06-18 08:28 UTC (History)
5 users (show)

Fixed In Version: harfbuzz-0.9.20-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 10:02:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2013-08-27 12:59:12 UTC
src/hb-buffer-serializer.cc:_hb_buffer_serialize_glyphs_json() misuses return value from snprintf().  Same for _hb_buffer_serialize_glyphs_text() and hbsrc/hb-shape.cc:_feature_to_string().  These cases are likely harmless because they do not happen inside a loop which could actually overflow the buffer.

Comment 2 Behdad Esfahbod 2013-08-27 14:50:09 UTC
In all three cases it's guaranteed that they don't overflow the buffer.  I'm still not sure how this is "misuse".  As such, I'm not sure what there is to fix.

Comment 3 Behdad Esfahbod 2013-08-27 14:51:02 UTC
Ok, I now understand what you mean by misuse.  But I think the code is fine the way it is.

Comment 4 Florian Weimer 2013-08-27 15:05:45 UTC
What I meant: snprintf can return -1 on error (glibc calls malloc in some cases which could fail; the Harfbuzz code doesn't deal with that), and if the buffer is too small, it returns the non-truncated number of characters, not the length of the truncated string.

Comment 5 Behdad Esfahbod 2013-08-27 15:47:08 UTC
Pushed out a fix for the negative return.  Thanks.

Comment 6 Parag Nemade 2013-08-30 07:55:38 UTC
Thanks behdad for quick fix. I have built harfbuzz-0.9.20-1.el7 now.

Comment 9 Parag Nemade 2014-01-14 11:22:27 UTC
I am going to file errata as errata is needed for each package against whom bug is available and fixed.

Florian,
   I suppose when Akira gave devel-ack+, bugbot should have changed bug status from ON_QA to MODIFIED.

Comment 13 Ludek Smid 2014-06-13 10:02:09 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.