Bug 1002207 - remove unused parameter and correctly handle mem alloc failure
Summary: remove unused parameter and correctly handle mem alloc failure
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: stripe
Version: mainline
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1133266
TreeView+ depends on / blocked
 
Reported: 2013-08-28 15:42 UTC by Kaleb KEITHLEY
Modified: 2014-08-24 06:44 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
: 1133266 (view as bug list)
Environment:
Last Closed: 2014-01-17 16:37:02 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Kaleb KEITHLEY 2013-08-28 15:42:24 UTC 
Description of problem:

gf_memdup() has only a single user, namely the stripe translator. Does it warrant being in libglusterfs for just a single user?

It has an unused parameter.

The stripe xlator updates its idea of how long the xattrs are even if the memory allocation failed.


Version-Release number of selected component (if applicable):

all

How reproducible:

code examination

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Anand Avati 2013-08-28 17:15:23 UTC 
REVIEW: http://review.gluster.org/5716 (stripe: remove unused param, handle mem alloc failure) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)
Comment 2 Anand Avati 2013-08-28 17:35:44 UTC 
REVIEW: http://review.gluster.org/5716 (stripe: remove unused param, handle mem alloc failure) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)
Comment 3 Anand Avati 2013-08-28 18:33:34 UTC 
REVIEW: http://review.gluster.org/5716 (stripe: remove unused param, handle mem alloc failure) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)
Comment 4 Anand Avati 2013-08-28 23:59:24 UTC 
COMMIT: http://review.gluster.org/5716 committed in master by Anand Avati (avati) 
------
commit b880b6b2908ad4e4afc8e26613bd0db8f0b28750
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Wed Aug 28 22:43:41 2013 +0530

    stripe: remove unused param, handle mem alloc failure
    
    Change-Id: I9c27b1edab111031ca8eea9cc49480ea01e39089
    BUG: 1002207
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/5716
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>
Note You need to log in before you can comment on or make changes to this bug.