Red Hat Bugzilla – Bug 1002694
pkgdb-cli orphan --retire toggles retirement state
Last modified: 2013-11-27 16:23:37 EST
Description of problem:
pkgdb-cli orphan --retire toggles the retirement state instead of ensuring that the package will be retired. This will cause unexpected behaviour if a cvsadmin used "fedpkg retire" on a branch that has been retired in packagedb but does not contain a dead.package file. Please change the command to never unretire a package, e.g. by checking whether a packge is already retired before trying to retire it.
This should be fixed in git, I would be most grateful if you could test it :)
Created attachment 794498 [details]
remove duplicate code in retire codepath
I applied the attached patch to remove the duplicate code from packagedb that confuses me.
If I understand the code correcty, it checks whether the branch the package should be retired in is in _get_active_branches(packagename, 1). This is the result for easymock3, which is currently retired in f20 (deprecated, statuscode 20) and orphaned in devel (statuscode 14), however "devel" is not in the result but f20 is:
In : _get_active_branches("easymock3", 1)
Out: [u'f18', u'f20', u'f19']
Also the package is approved in f19 (statuscode 3), so the check does not make sense. Instead of spending too much time in debugging/enhancing this, I want to try if it is possible to adapt packagedb to allow to sanely retire packages directly:
Thanks for the patch, it's applied and pushed in git.
I see now that I was checking the status of the collection rather than the status of the package. Should be fixed in git now.
>>> _get_active_branches("easymock3", 20)
[u'f18', u'f19', u'devel']
Created attachment 795085 [details]
Adjustments to make retire work as expected
With this patch retirement seems to work as expected with the current git.
packagedb-cli-1.6.0-1.el5 has been submitted as an update for Fedora EPEL 5.
packagedb-cli-1.6.0-1.fc19 has been submitted as an update for Fedora 19.
packagedb-cli-1.6.0-1.fc18 has been submitted as an update for Fedora 18.
packagedb-cli-1.6.0-1.fc20 has been submitted as an update for Fedora 20.
packagedb-cli-1.6.0-1.el6 has been submitted as an update for Fedora EPEL 6.
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing packagedb-cli-1.6.0-1.fc20'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
packagedb-cli-1.6.0-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
packagedb-cli-1.6.0-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
packagedb-cli-1.6.0-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
packagedb-cli-1.6.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
packagedb-cli-1.6.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.