Created attachment 792589 [details] logs and screenshot Description of problem: When RemoveStorageDomainCommand with format=true (on ISO domain) fails due to VDSNetworkException, engine reports on UI this error: "Error while executing action Remove Storage Domain: Internal Engine Error" This massage is not informative enough, engine should report about the real problem, which is the connectivity issue with vdsm. on engine.log we get this: 2013-09-01 14:35:57,418 ERROR [org.ovirt.engine.core.bll.storage.ConnectStorageToVdsCommand] (ajp-/127.0.0.1:8702-6) Command org.ovirt.engine.core.bll.storage.ConnectStorageToVdsCommand throw Vdc Bll exception. Wi th error message VdcBLLException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSNetworkException: java.net.SocketException: Connection reset (Failed with error VDS_NETWORK_ERROR and code 5022) Version-Release number of selected component (if applicable): rhevm-3.3.0-0.16.master.el6ev.noarch rhevm-webadmin-portal-3.3.0-0.16.master.el6ev.noarch How reproducible: 100% Steps to Reproduce: 1. have an ISO domain and detach it from DC 2. remove the domain with format, and restart vdsm during the action Actual results: Engine fails to send the RemoveStorageDomainCommand to vdsm and We get the mentioned error on UI Expected results: engine should report about the real problem, which is the connectivity issue with vdsm. Additional info: logs and screenshot
Engine should only print an audit log which indicates there was a failure removing the storage domain
The error should seep through the storage helpers to the remove Storage Domain Command. Right now the storage helpers only return boolean value and therefore the indication of the error get lost from that point beyond.
this bug status was moved to MODIFIED before engine vt5 was built, hence moving to on_qa, if this was mistake and the fix isn't in, please contact rhev-integ
Created attachment 946725 [details] engine.log Still getting "Error while executing action Remove Storage Domain: Internal Engine Error" when I try to remove an ISO domain with format while VDSM cannot access the storage. Used rhev3.5 vt5 Re-openning Attaching the logs
Did you try to reproduce with the exact steps to reproduce? Because it might be a different error than VDS_NETWORK_ERROR
After discussing with eedri, it seems that this fix did not make it into vt5, moving to modified and it will be featured in the next version
(In reply to Tal Nisan from comment #7) > After discussing with eedri, it seems that this fix did not make it into > vt5, moving to modified and it will be featured in the next version Will test it in the next build
The error message thrown is informative and not generic when ISO domain format fails due to connection loss: "Error while executing action Remove Storage Domain: Problem while trying to mount target" Verified using rhev3.5 vt6
RHEV-M 3.5.0 has been released, closing this bug.