lv2-x42-plugins - a collection of LV2 audio plugins This contains 5 plugins. A faser, convolver, balance, stereo panner etc. SRPM: http://bsjones.fedorapeople.org/reviews/lv2-x42-plugins-0.0.1-1.fc19.src.rpm SPEC: http://bsjones.fedorapeople.org/reviews/lv2-x42-plugins.spec REVIEW: http://bsjones.fedorapeople.org/reviews/lv2-x42-plugins-review.txt
- The URL for the source is missing. Please see [1] for the guidelines on github urls - According to the ChangeLog, the version is 0.1.1 - For post-release snapshots, follow the guidelines here [2], i.e. append .git%{shortcommit} to Release - Detail: you could replace "make install DESTDIR=%{buildroot}" by "%make_install" (see rpm -E '%make_install') Rest looks good! [1] http://fedoraproject.org/wiki/Packaging:SourceURL#Github [2] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
OK, there is no tag to grab the source as outlined in [1] above, so I have used a combination of it and pre-release syntax. SRPM: http://bsjones.fedorapeople.org/reviews/lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc19.src.rpm SPEC: http://bsjones.fedorapeople.org/reviews/lv2-x42-plugins.spec
For the SOURCE URL, you could use https://github.com/x42/x42-plugins/archive/%{commit}/x42-plugins-%{commit}.tar.gz and drop the date (i.e. %prerelease) from Release. Then, you would not need to use lv2-x42-plugins-snapshot.sh anymore. But I'll leave this for you to decide. Everything else is ok. Approved!
New Package SCM Request ======================= Package Name: lv2-x42-plugins Short Description: a collection of MIDI and audio plugins Owners: bsjones Branches: f18 f19 f20 InitialCC:
Git done (by process-git-requests).
lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc19
lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc20
lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc18
lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc20 has been pushed to the Fedora 20 testing repository.
lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc19
lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc20
lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc18
lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc20 has been pushed to the Fedora 20 stable repository.
lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.