Spec URL: http://scientific.zcu.cz/fedora/glite-lb-client-6.0.7-1/glite-lb-client.spec SRPM URL: <http://scientific.zcu.cz/fedora/glite-lb-client-6.0.7-1/glite-lb-client-6.0.7-1.fc21.src.rpm Description: glite-lb-client is the library implementing client side of gLite Logging and Bookkeeping API. glite-lb-client-progs package contains client programs and examples for gLite L&B. Fedora Account System Username: valtri Notes: - I'm upstream maintainer - there are already three patches (based on issues from other reviews), they will be included in the next release - koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5886873
Spec URL: http://scientific.zcu.cz/fedora/glite-lb-client-6.0.8-1/glite-lb-client.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-client-6.0.8-1/glite-lb-client-6.0.8-1.fc21.src.rpm New upstream release: - patches could be removed from the package - koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6215844
Let me help glite packages. ;)
1. Requires: glite-jobid-api-cpp-devel Where is the %{?_isa} at the ending? 2. install -m 0644 LICENSE project/ChangeLog $RPM_BUILD_ROOT%{_pkgdocdir} Better use %doc in %files 3. %{_mandir}/man1/glite-lb-notify.1.gz %{_mandir}/man1/glite-lb-logevent.1.gz Please use glob: %{_mandir}/man1/glite-lb-notify.1* %{_mandir}/man1/glite-lb-logevent.1* So RPM will help compress it if it doesn't. --------------------- PACKAGE APPROVED. Fix issues above before SCM import.
Thanks for the review! This is milestone, gLite L&B clients in native Fedora/EPEL repositories. :-) Fixing/explaining issues: 1. glite-jobid-api-cpp-devel is noarch package (contains only header files), so %{?_isa} has not been used 2. fixed (also in other gLite packages) 3. there is problem when combining %doc with listing installed documentation files; it is working OK on Fedora, but rpmbuild fails for EPEL 5/6: error: File not found: /builddir/build/BUILDROOT/glite-lb-client-6.0.8-1.git20131206.el6.x86_64/usr/share/doc/glite-lb-client-6.0.8/examples error: File not found by glob: /builddir/build/BUILDROOT/glite-lb-client-6.0.8-1.git20131206.el6.x86_64/usr/share/doc/glite-lb-client-6.0.8/examples/* File not found: /builddir/build/BUILDROOT/glite-lb-client-6.0.8-1.git20131206.el6.x86_64/usr/share/doc/glite-lb-client-6.0.8/examples File not found by glob: /builddir/build/BUILDROOT/glite-lb-client-6.0.8-1.git20131206.el6.x86_64/usr/share/doc/glite-lb-client-6.0.8/examples/* I added a comment to spec. The new version: Spec URL: http://scientific.zcu.cz/fedora/glite-lb-client-6.0.8-2/glite-lb-client.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-client-6.0.8-2/glite-lb-client-6.0.8-2.fc21.src.rpm
Fine. You can request SCM now.
New Package SCM Request ======================= Package Name: glite-lb-client Short Description: gLite Logging and Bookkeeping client library and programs Owners: valtri Branches: f18 f19 f20 el6 InitialCC:
Git done (by process-git-requests).
glite-lb-client-6.0.8-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/glite-lb-client-6.0.8-2.fc20
glite-lb-client-6.0.8-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/glite-lb-client-6.0.8-2.fc19
glite-lb-client-6.0.8-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/glite-lb-client-6.0.8-2.fc18
glite-lb-client-6.0.8-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/glite-lb-client-6.0.8-2.el6
glite-lb-client-6.0.8-2.fc20 has been pushed to the Fedora 20 testing repository.
glite-lb-client-6.0.8-2.fc20 has been pushed to the Fedora 20 stable repository.
glite-lb-client-6.0.8-2.fc19 has been pushed to the Fedora 19 stable repository.
glite-lb-client-6.0.8-2.fc18 has been pushed to the Fedora 18 stable repository.
glite-lb-client-6.0.8-2.el6 has been pushed to the Fedora EPEL 6 stable repository.