Bug 1005009 - File spice-client-glib-usb-acl-helper has no suid root privilege
Summary: File spice-client-glib-usb-acl-helper has no suid root privilege
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: spice-gtk
Version: 7.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: rc
: ---
Assignee: Christophe Fergeau
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-06 02:45 UTC by tingting zheng
Modified: 2014-06-18 01:04 UTC (History)
10 users (show)

Fixed In Version: spice-gtk-0.20-6.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 12:07:06 UTC
Target Upstream Version:

Attachments (Terms of Use)
Debug info from virt-manager (6.27 KB, text/plain)
2013-09-06 02:45 UTC, tingting zheng 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description tingting zheng 2013-09-06 02:45:49 UTC 
Created attachment 794559 [details]
Debug info from virt-manager

Description
File spice-client-glib-usb-acl-helper has no suid root privilege

Version:
libvirt-1.1.1-3.el7.x86_64
virt-manager-0.10.0-3.el7.noarch
spice-glib-0.20-2.el7.x86_64
spice-gtk-0.20-2.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Use non-root user login system.
2. Launch virt-manager,input password for authentication.
3. Configure a guest to try usb auto redirection.
4. Error shows:
spice-client-glib-usb-helper: Error setting facl: Operation not permitted

5. Check the mode of file spice-client-glib-usb-helper
# ll /usr/libexec/spice-gtk-x86_64/spice-client-glib-usb-acl-helper 
-rwxr-xr-x. 1 root root 15448 Jul 12 01:03 /usr/libexec/spice-gtk-x86_64/spice-client-glib-usb-acl-helper
6. add suid root privilege to the file,usb can be redirected successfully.

Actual results：
As description.

Expected results:
File spice-client-glib-usb-acl-helper has suid root privilege

Additional info:
Attached virt-manager debug info.
Comment 3 Christophe Fergeau 2013-09-06 16:20:24 UTC 
http://download.devel.redhat.com/brewroot/packages/spice-gtk/0.20/2.el7/data/logs/x86_64/build.log has:
chown root /builddir/build/BUILDROOT/spice-gtk-0.20-2.el7.x86_64/usr/libexec/spice-gtk-x86_64//spice-client-glib-usb-acl-helper
chown: changing ownership of '/builddir/build/BUILDROOT/spice-gtk-0.20-2.el7.x86_64/usr/libexec/spice-gtk-x86_64//spice-client-glib-usb-acl-helper': Operation not permitted
chmod u+s  /builddir/build/BUILDROOT/spice-gtk-0.20-2.el7.x86_64/usr/libexec/spice-gtk-x86_64//spice-client-glib-usb-acl-helper

Iirc spice-client-glib-usb-acl-helper needs to be added to some magic list in order to be suid-able, and iirc Hans did what was needed for that to happen. Maybe just a rebuild is needed?
Comment 4 Christophe Fergeau 2013-09-13 12:02:12 UTC 
Ah I guess we need http://pkgs.fedoraproject.org/cgit/spice-gtk.git/commit/?id=549771495ae0f264042487c5dff01028368178e2 as well
Comment 5 Christophe Fergeau 2013-09-13 14:14:04 UTC 
Should be fixed by a new spice-gtk build.
Comment 10 Ludek Smid 2014-06-13 12:07:06 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.
Note You need to log in before you can comment on or make changes to this bug.