Bug 1005186 – Unable to undefine attribute enable-welcome-root for virtual server via CLI

Bug 1005186 - Unable to undefine attribute enable-welcome-root for virtual server via CLI

Summary:	Unable to undefine attribute enable-welcome-root for virtual server via CLI

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	JBoss Enterprise Application Platform 6
Classification:	JBoss
Component:	Web (Show other bugs)
Sub Component:
Version:	6.1.1
Hardware:	Unspecified Unspecified

Priority	unspecified Severity medium
Target Milestone:	ER7
Target Release:	EAP 6.2.0
Assigned To:	Chao Wang
QA Contact:	Radim Hatlapatka
Docs Contact:	Russell Dickenson

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2013-09-06 07:36 EDT by Radim Hatlapatka
Modified:	2013-12-15 11:20 EST (History)
CC List:	2 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2013-12-15 11:20:17 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Radim Hatlapatka 2013-09-06 07:36:45 EDT

Description of problem:
Instead of attribute enable-welcome-root being undefined it is set to a default value

Version-Release number of selected component (if applicable):
EAP 6.1.1

How reproducible: always


Steps to Reproduce:
1. /subsystem=web/virtual-server=default-host:undefine-attribute(name=enable-welcome-root)
2. /subsystem=web/virtual-server=default-host:read-attribute(include-defaults=false, name=enable-welcome-root)


Actual results:

false

Expected results:

undefined


Additional info:
read-resource-description shows that this attribute is nillable

Comment 1 Chao Wang 2013-09-27 04:49:56 EDT

This because that SimpleAttribute 'enable-welcome-root' is nillable but has a default value set to false and WriteEnableWelcomeRoot considers all non-true value as a false value, Thus, user can't undefine it.

I have prepared a fix on https://github.com/soul2zimate/jboss-eap/commit/848349cec769600e7be012b9bfc2ca759a41b367

However, I wonder if it's intended to work like that? if true, we only need to revise attribute description to non-nullable and accept false as default value.

Comment 3 Radim Hatlapatka 2013-11-04 07:34:44 EST

Verified in EAP 6.2.0.ER7

Note You need to log in before you can comment on or make changes to this bug.