Spec URL: http://fedora.lowlatency.de/review/wmdocker.spec SRPM URL: http://fedora.lowlatency.de/review/wmdocker-1.5-11.fc19.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=5907199 Description: Docker is a docking application (WindowMaker dock app) which acts as a system tray for KDE and GNOME2. It can be used to replace the panel in either environment, allowing you to have a system tray without running the KDE/GNOME panel or environment. Fedora Account System Username: awjb See https://fedorahosted.org/fpc/ticket/341.
Note as per https://fedorahosted.org/fpc/ticket/341#comment:7, it is okay to omit "Provides: docker" (and this spec file does). Obsoletes is also properly provided, with a conditional for < f22. (That can, of course, be dropped in the future, but the conditional seems like a good idea too.)
A few small things on review: - the license should actually be "GPLv2+", not "GPL". - you can drop the %defattr if you like - same with Buildroot - and with %clean section And a bigger question: do we want to rename the binary to wmdocker?
Thanks for taking up the review. I will change the stuff you pointed out asap. I thought about the rename myself but came to the conclusion that if we provide a clean upgrade path users will probably have a smooth transition package wise but will be missing their docker dockapp... if they pinpoint it to the rename it is not a problem however. Will the new docker package provide a docker binary?
Yes, it has a docker binary, and that's much harder to change than the package name, since a lot of external documentation will talk about it (and the upstream is very concerned about a pleasant/seamless/same-everywhere user experience).
Ok, before we add a conflicts I will rename the binary as well.
Spec URL: http://fedora.lowlatency.de/review/wmdocker.spec SRPM URL: http://fedora.lowlatency.de/review/wmdocker-1.5-12.fc20.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=5920736
whoops sorry for dropping this on the floor for a bit there. Review passed.
New Package SCM Request ======================= Package Name: wmdocker Short Description: KDE and GNOME2 system tray replacement docking application Owners: awjb Branches: f20
Git done (by process-git-requests).