Bug 1005490 - Review Request: SDL2_mixer - Simple DirectMedia Layer - Sample Mixer Library
Summary: Review Request: SDL2_mixer - Simple DirectMedia Layer - Sample Mixer Library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-07 15:00 UTC by Igor Gnatenko
Modified: 2014-01-19 04:05 UTC (History)
4 users (show)

Fixed In Version: SDL2_mixer-2.0.0-3.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-19 04:05:30 UTC
Type: ---
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Igor Gnatenko 2013-09-07 15:00:16 UTC
Spec URL: http://ignatenkobrain.fedorapeople.org/for-review/SDL2_mixer.spec
SRPM URL: http://ignatenkobrain.fedorapeople.org/for-review/SDL2_mixer-2.0.0-1.fc20.src.rpm
Description: 
SDL_mixer is a sample multi-channel audio mixer library.
It supports any number of simultaneously playing channels of 16 bit stereo
audio, plus a single channel of music, mixed by the popular FLAC,
MikMod MOD, Timidity MIDI, Ogg Vorbis, and SMPEG MP3 libraries. 
Fedora Account System Username: ignatenkobrain

Comment 1 Björn 'besser82' Esser 2013-09-07 15:01:33 UTC
taken ;)

Comment 2 Igor Gnatenko 2013-09-08 16:22:41 UTC
Have not interested yet. Sorry for bug.

Comment 4 Christopher Meng 2013-11-18 09:55:30 UTC
Taken.

Comment 5 Christopher Meng 2013-11-20 10:32:52 UTC
Please:

1. Add these supports by BR:

i.  libmodplug-devel
ii. fluidsynth-devel
iii.libmikmod-devel

2. Remove

Requires:       pkgconfig

in -devel package.

3. License is not LGPLv2 of course, please correct.

4. This package should also be built with smpeg2 support, however this package is not in Fedora and may never be included in Fedora due to legal issues;) ) So ignore this comment...

Comment 6 Igor Gnatenko 2013-11-20 19:53:16 UTC
new SPEC: http://ignatenkobrain.fedorapeople.org/for-review/SDL2_mixer.spec
new SRPM: http://ignatenkobrain.fedorapeople.org/for-review/SDL2_mixer-2.0.0-3.fc20.src.rpm

* Wed Nov 20 2013 Igor Gnatenko <i.gnatenko.brain> - 2.0.0-3
- Add some BuildRequires (cicku)
- Delete pkgconfig from -devel subpackage (cicku)
- Removing external folder in prep section (ignatenkobrain)
- Fix license to correct zlib (cicku & ignatenkobrain)

Comment 7 Christopher Meng 2013-11-21 03:00:14 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (3 clause)", "LGPL (v2 or later) (with incorrect FSF address)",
     "Unknown or generated", "zlib/libpng". 60 files have unknown license.
     Detailed output of licensecheck:


BSD (3 clause)
--------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/FLAC/all.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/FLAC/assert.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/FLAC/callback.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/FLAC/export.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/FLAC/format.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/FLAC/metadata.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/FLAC/ordinals.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/FLAC/stream_decoder.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/FLAC/stream_encoder.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Headers/FLAC/all.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Headers/FLAC/assert.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Headers/FLAC/callback.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Headers/FLAC/export.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Headers/FLAC/format.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Headers/FLAC/metadata.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Headers/FLAC/ordinals.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Headers/FLAC/stream_decoder.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Headers/FLAC/stream_encoder.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/A/Headers/FLAC/all.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/A/Headers/FLAC/assert.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/A/Headers/FLAC/callback.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/A/Headers/FLAC/export.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/A/Headers/FLAC/format.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/A/Headers/FLAC/metadata.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/A/Headers/FLAC/ordinals.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/A/Headers/FLAC/stream_decoder.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/A/Headers/FLAC/stream_encoder.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/Current/Headers/FLAC/all.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/Current/Headers/FLAC/assert.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/Current/Headers/FLAC/callback.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/Current/Headers/FLAC/export.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/Current/Headers/FLAC/format.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/Current/Headers/FLAC/metadata.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/Current/Headers/FLAC/ordinals.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/Current/Headers/FLAC/stream_decoder.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/FLAC.framework/Versions/Current/Headers/FLAC/stream_encoder.h

LGPL (v2 or later) (with incorrect FSF address)
-----------------------------------------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/MPEGframe.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/smpeg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/smpeg2.framework/Headers/MPEGframe.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/smpeg2.framework/Headers/smpeg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/smpeg2.framework/Versions/A/Headers/MPEGframe.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/smpeg2.framework/Versions/A/Headers/smpeg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/smpeg2.framework/Versions/Current/Headers/MPEGframe.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/smpeg2.framework/Versions/Current/Headers/smpeg.h

Unknown or generated
--------------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/clean.sh
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/modplug.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/ogg/config_types.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/ogg/ogg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/ogg/os_types.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/vorbis/codec.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/external/include/vorbis/vorbisfile.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/VisualC/resource.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Ogg.framework/Headers/ogg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Ogg.framework/Headers/os_types.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Ogg.framework/Versions/A/Headers/ogg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Ogg.framework/Versions/A/Headers/os_types.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Ogg.framework/Versions/Current/Headers/ogg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Ogg.framework/Versions/Current/Headers/os_types.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Vorbis.framework/Headers/codec.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Vorbis.framework/Headers/vorbisenc.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Vorbis.framework/Headers/vorbisfile.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Vorbis.framework/Versions/A/Headers/codec.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Vorbis.framework/Versions/A/Headers/vorbisenc.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Vorbis.framework/Versions/A/Headers/vorbisfile.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Vorbis.framework/Versions/Current/Headers/codec.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Vorbis.framework/Versions/Current/Headers/vorbisenc.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/Vorbis.framework/Versions/Current/Headers/vorbisfile.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/modplug.framework/Headers/modplug.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/modplug.framework/Versions/A/Headers/modplug.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/Frameworks/modplug.framework/Versions/Current/Headers/modplug.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/pkg-support/codesign-frameworks.sh
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/pkg-support/mkpackage.sh
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/playmus/SDLMain.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/playmus/SDLMain.m
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/playwave/SDLMain.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/Xcode/playwave/SDLMain.m
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/autogen.sh
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/build-scripts/ltmain.sh
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/gcc-fat.sh
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/common.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/common.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/config.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/ctrlmode.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/ctrlmode.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/filter.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/filter.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/instrum.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/instrum.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/mix.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/mix.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/output.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/output.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/playmidi.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/playmidi.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/readmidi.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/readmidi.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/resample.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/resample.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/sdl_a.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/sdl_c.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/tables.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/tables.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/timidity.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/timidity/timidity.h

zlib/libpng
-----------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/SDL_mixer.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_flac.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_flac.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_fluidsynth.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_fluidsynth.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_mod.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_mod.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_modplug.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_modplug.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_mp3.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_mp3.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_ogg.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/dynamic_ogg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/effect_position.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/effect_stereoreverse.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/effects_internal.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/effects_internal.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/fluidsynth.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/fluidsynth.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/load_aiff.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/load_aiff.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/load_flac.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/load_flac.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/load_ogg.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/load_ogg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/load_voc.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/load_voc.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/mixer.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_cmd.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_cmd.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_flac.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_flac.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_mad.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_mad.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_mod.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_mod.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_modplug.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_modplug.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_ogg.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/music_ogg.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/native_midi/native_midi.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/native_midi/native_midi_common.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/native_midi/native_midi_common.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/native_midi/native_midi_haiku.cpp
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/native_midi/native_midi_mac.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/native_midi/native_midi_macosx.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/native_midi/native_midi_win32.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/playmus.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/playwave.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/wavestream.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/SDL2_mixer-2.0.0/wavestream.h

-----------------
As mixer is licensed under Zlib, and these LGPL stuffs are externel bundled code which have been removed in %prep so nothing should be emphasized now.

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: SDL2_mixer-2.0.0-3.fc21.i686.rpm
          SDL2_mixer-devel-2.0.0-3.fc21.i686.rpm
          SDL2_mixer-2.0.0-3.fc21.src.rpm
SDL2_mixer.i686: W: spelling-error %description -l en_US multi -> mulch, mufti
SDL2_mixer.i686: W: no-manual-page-for-binary playwave2
SDL2_mixer.i686: W: no-manual-page-for-binary playmus2
SDL2_mixer.src: W: spelling-error %description -l en_US multi -> mulch, mufti
3 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint SDL2_mixer-devel SDL2_mixer
SDL2_mixer.i686: W: spelling-error %description -l en_US multi -> mulch, mufti
SDL2_mixer.i686: W: no-manual-page-for-binary playwave2
SDL2_mixer.i686: W: no-manual-page-for-binary playmus2
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'



Requires
--------
SDL2_mixer-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    SDL2-devel
    SDL2_mixer(x86-32)
    libSDL2_mixer-2.0.so.0
    libvorbis-devel
    pkgconfig(sdl2)

SDL2_mixer (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libSDL2-2.0.so.0
    libSDL2_mixer-2.0.so.0
    libc.so.6
    libm.so.6
    libpthread.so.0
    rtld(GNU_HASH)



Provides
--------
SDL2_mixer-devel:
    SDL2_mixer-devel
    SDL2_mixer-devel(x86-32)
    pkgconfig(SDL2_mixer)

SDL2_mixer:
    SDL2_mixer
    SDL2_mixer(x86-32)
    libSDL2_mixer-2.0.so.0



Source checksums
----------------
http://www.libsdl.org/projects/SDL_mixer/release/SDL2_mixer-2.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : a8ce0e161793791adeff258ca6214267fdd41b3c073d2581cd5265c8646f725b
  CHECKSUM(SHA256) upstream package : a8ce0e161793791adeff258ca6214267fdd41b3c073d2581cd5265c8646f725b


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -rvn SDL2_mixer-2.0.0-3.fc20.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

----------------
PACKAGE APPROVED.

Comment 8 Igor Gnatenko 2013-11-21 09:16:45 UTC
New Package SCM Request
=======================
Package Name: SDL2_mixer
Short Description: Simple DirectMedia Layer - Sample Mixer Library
Owners: ignatenkobrain
Branches: f20

Comment 9 Gwyn Ciesla 2013-11-21 13:00:44 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2013-11-21 19:22:44 UTC
SDL2_mixer-2.0.0-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/SDL2_mixer-2.0.0-3.fc20

Comment 11 Fedora Update System 2013-11-24 03:42:00 UTC
SDL2_mixer-2.0.0-3.fc20 has been pushed to the Fedora 20 stable repository.

Comment 12 Igor Gnatenko 2014-01-17 17:19:30 UTC
Package Change Request
======================
Package Name: SDL2_mixer
New Branches: f19
Owners: ignatenkobrain

Want to get this package for f19

Comment 13 Gwyn Ciesla 2014-01-17 17:21:03 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2014-01-17 17:39:23 UTC
SDL2_mixer-2.0.0-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/SDL2_mixer-2.0.0-3.fc19

Comment 15 Fedora Update System 2014-01-19 04:05:30 UTC
SDL2_mixer-2.0.0-3.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.