Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-exception_notification.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-exception_notification-4.0.0-1.fc21.src.rpm Description: The Exception Notification gem provides a set of notifiers for sending notifications when errors occur in a Rack/Rails application. The built-in notifiers can deliver notifications by email, campfire rooms or via webhooks. Fedora Account System Username: ktdreyer Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5916345
Taking.
* description should end with dot. (-doc subpackage) * *I* would put README.md into main package (if you disagree, let it be) * *I* would keep the original %{gem_name}.gemspec and put it into -doc subpackage. It may be usefull for developers. (if you disagree, let it be) * remove executable attr from LICENSE rubygem-exception_notification.noarch: E: script-without-shebang /usr/share/gems/gems/exception_notification-4.0.0/LICENSE * .gitkeep can be removed rubygem-exception_notification-doc.noarch: W: hidden-file-or-dir /usr/share/gems/gems/exception_notification-4.0.0/test/dummy/public/stylesheets/.gitkeep rubygem-exception_notification-doc.noarch: E: zero-length /usr/share/gems/gems/exception_notification-4.0.0/test/dummy/public/stylesheets/.gitkeep rubygem-exception_notification-doc.noarch: W: hidden-file-or-dir /usr/share/gems/gems/exception_notification-4.0.0/test/dummy/lib/tasks/.gitkeep rubygem-exception_notification-doc.noarch: E: zero-length /usr/share/gems/gems/exception_notification-4.0.0/test/dummy/lib/tasks/.gitkeep Otherwise it looks good to me.
Thank you very much for reviewing. (In reply to Miroslav Suchý from comment #2) > * description should end with dot. (-doc subpackage) Fixed. (Thanks also for proposing https://github.com/lutter/gem2rpm/pull/25!) > * *I* would put README.md into main package (if you disagree, let it be) > > * *I* would keep the original %{gem_name}.gemspec and put it into -doc > subpackage. It may be usefull for developers. (if you disagree, let it be) For these two, I'll respectfully decline. My hope is to keep the packages light-weight if possible (particularly the main package, since that's likely to be installed in a lot of places). If it is important to be consistent, I think these could be proposed as changes to the Ruby Packaging Guidelines wiki page and gem2rpm template. > * remove executable attr from LICENSE > rubygem-exception_notification.noarch: E: script-without-shebang > /usr/share/gems/gems/exception_notification-4.0.0/LICENSE Great catch, thank you. > * .gitkeep can be removed Good catch, and I removed a .gitignore file as well. Package diff: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-exception_notification.git/commit/?id=0885d91392db166049312379d3cdcfc821c07ec6 Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-exception_notification.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-exception_notification-4.0.0-2.fc21.src.rpm Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5930644
> For these two, I'll respectfully decline. OK Everything else is good. APPROVED.
You rock, thanks a lot!
New Package SCM Request ======================= Package Name: rubygem-exception_notification Short Description: Exception notification for Rails apps Owners: ktdreyer Branches: f19 f20
Git done (by process-git-requests).
rubygem-exception_notification-4.0.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-exception_notification-4.0.0-2.fc20
rubygem-exception_notification-4.0.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-exception_notification-4.0.0-2.fc19
rubygem-exception_notification-4.0.0-2.fc19 has been pushed to the Fedora 19 testing repository.
Ken, please consider adding this gem to Upstream monitoring: https://fedoraproject.org/wiki/Upstream_release_monitoring
Thanks for the suggestion. I've added this gem (along with all my other gems) to the list.
rubygem-exception_notification-4.0.0-2.fc20 has been pushed to the Fedora 20 stable repository.
rubygem-exception_notification-4.0.0-2.fc19 has been pushed to the Fedora 19 stable repository.