Create a node with a couple of non-versionable children and 2 checkpoints for that node (via versionManager.checkpoint). After that, attempting to restore version "1.0" produces an exception.
Horia Chiorean <hchiorea> made a comment on jira MODE-2034 Fixed the restore operation of a parent with 2 unversioned children. [~angelo.chen] thanks for the submitted files, the fix is very similar to your changes.
Angelo Chen <angelo.chen> made a comment on jira MODE-2034 @Horia Chiorean, I'm not sure whether the rename has the same issue. - // See if this child has been removed ... - if (changes.isRemoved(next)) continue; + // See if this child has been removed but not inserted ... + if (changes.isRemoved(next) && changes.inserted(next.getKey()) == null) continue; how about the child has been removed and renamed?
Angelo Chen <angelo.chen> made a comment on jira MODE-2034 @hchiorean, I'm not sure whether the rename has the same issue. - // See if this child has been removed ... - if (changes.isRemoved(next)) continue; + // See if this child has been removed but not inserted ... + if (changes.isRemoved(next) && changes.inserted(next.getKey()) == null) continue; how about the child has been removed and renamed?
Horia Chiorean <hchiorea> made a comment on jira MODE-2034 [~angelo.chen]: a node should not appear both as removed and renamed, from a transient changes perspective. This is only specific to "orderBefore".
Randall Hauch <rhauch> made a comment on jira MODE-2034 Rebased and merged the PR into the 'master' branch. Leaving open to be cherry-picked onto '3.3.x-prod-ip6.0'.
https://github.com/jboss-integration/modeshape/commit/086a09ea5a74aae262392db126c27b5bf8479c80
Randall Hauch <rhauch> updated the status of jira MODE-2034 to Closed
Fixed before GA - setting to requires_doc_text- accordingly
Fix verified in GA.