Red Hat Bugzilla – Bug 1006411
Hardcoded references to "localhost:8080"
Last modified: 2014-08-06 16:07:27 EDT
Description of problem:
There are few resources in BPMS that hard code localhost:8080. When using a port offset this breaks the designer and has some other unknown affects.
The current workaround to fix the JBPM designer is to set the 'designer.url' property to the appropriate port when using a port offset. The expectation would be detect the main web port instead of having to control it through a property.
# is backbone used, and will this load?
./standalone/deployments/business-central.war/org.kie.workbench.KIEWebapp/defaults/formwidgets/backboneformsinclude.fw:<script src="http://localhost:8080/designer/lib/backbone-forms-min.js" charset="utf-8"></script>
./standalone/deployments/business-central.war/org.kie.workbench.KIEWebapp/defaults/formwidgets/backboneformsinclude.fw:<script src="http://localhost:8080/designer/lib/backbone-forms-list-min.js" charset="utf-8"></script>
./standalone/deployments/business-central.war/org.kie.workbench.KIEWebapp/defaults/formwidgets/backboneformsinclude.fw:<link href="http://localhost:8080/designer/lib/backbone-forms-default.css" rel="stylesheet" />
# Property must be overridden when using a port offset - can this be detected automatically instead?
### group.addConfigItem( configurationFactory.newConfigItem( "designer.url", "http://localhost:8080" ) );
Binary file ./standalone/deployments/business-central.war/WEB-INF/classes/org/kie/workbench/backend/AppSetup.class matches
./standalone/deployments/business-central.war/WEB-INF/classes/org/kie/workbench/backend/AppSetup.java: "http://localhost:8080" ) );
Version-Release number of selected component (if applicable):
100% of the time for designer issue
Unknown affects for the
Steps to Reproduce:
1. Install BPMS on EAP 6.
2. Start the server with a port offset (ex: bin/standalone.sh -Djboss.socket.binding.port-offset=1)
3a. Check that you can edit a JBPM process
3b. Try to create a data model and save it
We absolutely need to fix this for GA. But it is OK if it is not tackled for Beta.
Internal Whiteboard: Beta Blocker → Blocker
Not critical for Beta, but need to address for GA
Removed all references to localhost from the form widgets. Tested designer with -Djboss.socket.binding.port-offset=1 and things seem fine. If there are issues with data modeler please assign to appropriate devels for that. Fix for designer in its master and 6.0.x branches.
File AppSetup.class still hardcodes http://localhost:8080. If this is intended and does not represent a problem then please explain why. Thanks.
You mean https://github.com/droolsjbpm/jbpm-designer/blob/master/jbpm-designer-standalone/src/main/java/org/jbpm/designer/uberfire/backend/server/impl/AppSetup.java - there are no references to localhost. Maybe tho it comes from somewhere else so will take a look.
Tiho, see https://github.com/droolsjbpm/kie-wb-distributions/blob/6.0.x/kie-wb/kie-wb-webapp/src/main/java/org/kie/workbench/backend/AppSetup.java#L141
Marek, we believe this is no longer used, verifying.
If you can confirm that it's not used anywhere then please move the state back to ON_QA and I will close it. Thanks a lot guys!
Verified on ER6.