Red Hat Bugzilla – Bug 1006917
Failed repository clone with user and password give plaintext view password in popup and logs
Last modified: 2014-08-06 16:13:33 EDT
Created attachment 796383 [details] error popup with plaintext password Description of problem: When git repository is cloned incorrectly with a password specified, umasked password is shown in error message and logs Version-Release number of selected component (if applicable): ER2 How reproducible: Clone a repo with a bad GIT URI and user and password. Steps to Reproduce: 1. Clone repository 2. fill in invalid GIT URI 3. fill in user and password 4. submit Actual results: Pop up with plain text password and in logs, see below for log message. Expected results: No passwords plain text anywhere. Additional info: (error in logs) 09:43:54,022 ERROR [stderr] (http-localhost/127.0.0.1:8080-2) Message: CommandType=createRepository:java.lang.String:java.lang.String:java.util.Map:, ErrorTo=org.uberfire.backend.repositories.RepositoryService:RPC.createRepository:java.lang.String:java.lang.String:java.util.Map::Errors:16, ReplyTo=org.uberfire.backend.repositories.RepositoryService:RPC.createRepository:java.lang.String:java.lang.String:java.util.Map::RespondTo:16, ToSubject=org.uberfire.backend.repositories.RepositoryService:RPC, MethodParms=[git, testvalidateurl, {username=erics, origin=http://www.schabell.org/fun.git, crypt:password=damnitisplaintext}]
Fixed on UberFire master and 0.3.x branches: https://github.com/droolsjbpm/uberfire/commit/02f718600 https://github.com/droolsjbpm/uberfire/commit/f88cdcdb0
Verified on BPMS 6.0.0.ER4