Bug 1007247 - Review Request: php-phpunit-phpcov - TextUI frontend for PHP_CodeCoverage
Summary: Review Request: php-phpunit-phpcov - TextUI frontend for PHP_CodeCoverage
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-12 08:06 UTC by Remi Collet
Modified: 2013-11-10 07:53 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2013-10-31 03:03:50 UTC
shawn: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpci.log (8.17 KB, text/x-log)
2013-10-21 18:27 UTC, Shawn Iwinski
no flags Details
review.txt (7.68 KB, text/plain)
2013-10-21 18:27 UTC, Shawn Iwinski
no flags Details

Comment 1 Shawn Iwinski 2013-10-21 18:27:03 UTC
Created attachment 814734 [details]
phpci.log

phpcompatinfo version 2.23.1

Comment 2 Shawn Iwinski 2013-10-21 18:27:36 UTC
Created attachment 814735 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1007247
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

Comment 3 Shawn Iwinski 2013-10-21 18:31:39 UTC
> php-phpunit-phpcov.noarch: W: spelling-error Summary(en_US) frontend -> fronted, front end, front-end
> php-phpunit-phpcov.noarch: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end

Perhaps change "frontend" to "front-end"

> php-phpunit-phpcov.noarch: W: no-manual-page-for-binary phpcov

Perhaps add a man file with the help of help2man.



No blockers.

===== APPROVED =====

Comment 4 Remi Collet 2013-10-22 04:50:44 UTC
Thanks for the review.
I will take care of your comment after import.


New Package SCM Request
=======================
Package Name: php-phpunit-phpcov
Short Description: TextUI frontend for PHP_CodeCoverage
Owners: remi
Branches: f19 f20 el6
InitialCC:

Comment 5 Gwyn Ciesla 2013-10-22 12:14:15 UTC
Git done (by process-git-requests).

Comment 6 Remi Collet 2013-10-22 15:48:43 UTC
@Shawn: FYI after some try, I prefer to not provide any generated man page. It's quite ugly to generate (path, include_path...) and result is not really correct (usage line not correctly retrieved, and splited in SYNOPSIS and DESCRIPTION).

Comment 7 Fedora Update System 2013-10-22 15:50:55 UTC
php-phpunit-phpcov-1.1.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-phpunit-phpcov-1.1.0-1.fc20

Comment 8 Fedora Update System 2013-10-22 15:51:10 UTC
php-phpunit-phpcov-1.1.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/php-phpunit-phpcov-1.1.0-1.fc19

Comment 9 Fedora Update System 2013-10-22 15:51:21 UTC
php-phpunit-phpcov-1.1.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-phpunit-phpcov-1.1.0-1.el6

Comment 10 Fedora Update System 2013-10-22 18:53:05 UTC
php-phpunit-phpcov-1.1.0-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 11 Fedora Update System 2013-10-31 03:03:50 UTC
php-phpunit-phpcov-1.1.0-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 12 Fedora Update System 2013-11-06 18:27:56 UTC
php-phpunit-phpcov-1.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 13 Fedora Update System 2013-11-10 07:53:30 UTC
php-phpunit-phpcov-1.1.0-1.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.