Bug 1007990 - depmod: WARNING: ... kernel/drivers/char/crash.ko needs unknown symbol page_is_ram
Summary: depmod: WARNING: ... kernel/drivers/char/crash.ko needs unknown symbol page...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-13 17:14 UTC by H.J. Lu
Modified: 2013-09-18 20:57 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-18 20:57:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description H.J. Lu 2013-09-13 17:14:58 UTC
crash-driver.patch has

diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index be1ef57..ac659f7 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -24,6 +24,8 @@
 
 #include "physaddr.h"
 
+EXPORT_SYMBOL_GPL(page_is_ram);
+
 /*
  * Fix up the linear direct mapping of the kernel to avoid cache attribute
  * conflicts.

But kernel 3.11 has

commit c5a130325f13b219438cb100e2da71a3e31199f3
Author: Chen Gong <gong.chen.com>
Date:   Thu Jun 6 15:20:51 2013 -0700

    ACPI/APEI: Add parameter check before error injection
    
    When param1 is enabled in EINJ but not assigned with a valid
    value, sometimes it will cause the error like below:
    
    APEI: Can not request [mem 0x7aaa7000-0x7aaa7007] for APEI EINJ Trigger registers
    
    It is because some firmware will access target address specified in
    param1 to trigger the error when injecting memory error. This will
    cause resource conflict with regular memory. So It must be removed
    from trigger table resources, but incorrect param1/param2
    combination will stop this action. Add extra check to avoid
    this kind of error.
    
    Signed-off-by: Chen Gong <gong.chen.com>
    Signed-off-by: Tony Luck <tony.luck>

with

diff --git a/kernel/resource.c b/kernel/resource.c
index d738698..77bf11a 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -409,6 +409,7 @@ int __weak page_is_ram(unsigned long pfn)
 {
   return walk_system_ram_range(pfn, 1, NULL, __is_ram) == 1;
 }
+EXPORT_SYMBOL_GPL(page_is_ram);
 
 void __weak arch_remove_reservations(struct resource *avail)
 {

Now page_is_ram is exported twice, which leads to

nm vmlinux| grep page_is_ram
ffffffff81aac70d r __kstrtab_page_is_ram
ffffffff81aaced5 r __kstrtab_page_is_ram
ffffffff81aa6d70 r __ksymtab_page_is_ram
ffffffff81aa6d80 r __ksymtab_page_is_ram
ffffffff8106e690 W page_is_ram

Installing kernel 3.11 rpm generates:

depmod:  WARNING:  ... kernel/drivers/char/crash.ko needs unknown symbol page_is_ram

diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index be1ef57..ac659f7 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -24,6 +24,8 @@
 
 #include "physaddr.h"
 
+EXPORT_SYMBOL_GPL(page_is_ram);
+
 /*
  * Fix up the linear direct mapping of the kernel to avoid cache attribute
  * conflicts.

should be removed from crash-driver.patch in kernel 3.11 and above.

Comment 1 H.J. Lu 2013-09-13 17:20:10 UTC
It has been fixed in Fedora 20:

commit f334b4707438a8936f069c845e6a089aa9de697f
Author: Kyle McMartin <kmcmarti>
Date:   Wed Jul 10 10:33:31 2013 -0400

    Fix crash-driver.patch to properly use page_is_ram.

Comment 2 Josh Boyer 2013-09-13 17:35:47 UTC
THanks, fixed.

Comment 3 Josh Boyer 2013-09-18 20:40:25 UTC
*********** MASS BUG UPDATE **************

We apologize for the inconvenience.  There is a large number of bugs to go through and several of them have gone stale.  Due to this, we are doing a mass bug update across all of the Fedora 19 kernel bugs.

Fedora 19 has now been rebased to 3.11.1-200.fc19.  Please test this kernel update and let us know if you issue has been resolved or if it is still present with the newer kernel.

If you experience different issues, please open a new bug report for those.

Comment 4 H.J. Lu 2013-09-18 20:55:56 UTC
Fixed with 3.11.1-200.fc19.


Note You need to log in before you can comment on or make changes to this bug.