Bug 1008527 - (qt5-qtquickcontrols) Review Request: qt5-qtquickcontrols - Qt5 - module with set of QtQuick controls
Review Request: qt5-qtquickcontrols - Qt5 - module with set of QtQuick controls
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Rex Dieter
Fedora Extras Quality Assurance
: Reopened
Depends On:
Blocks: qt-reviews
  Show dependency treegraph
 
Reported: 2013-09-16 10:28 EDT by Lubomir Rintel
Modified: 2013-10-18 14:51 EDT (History)
6 users (show)

See Also:
Fixed In Version: qt5-qtquickcontrols-5.1.1-2.el6
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-10-14 03:01:43 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rdieter: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Lubomir Rintel 2013-09-16 10:28:55 EDT
SPEC: http://v3.sk/~lkundrak/SPECS/qt5-qtquickcontrols.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/qt5-qtquickcontrols-5.1.1-1.fc20.src.rpm

Description:

The Qt Quick Controls module provides a set of controls that can be used to 
build complete interfaces in Qt Quick.
Comment 1 Christopher Meng 2013-09-16 10:30:31 EDT
What's your FAS username?
Comment 2 Lubomir Rintel 2013-09-16 10:36:01 EDT
(In reply to Christopher Meng from comment #1)
> What's your FAS username?

lkundrak
Comment 3 Rex Dieter 2013-09-22 16:00:20 EDT
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5969150

$ rpmlint *.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

naming: ok

licensing: ok ... mostly. you could probably drop BSD reference since that is only used in (currently unpackaged) examples.

macros: ok

scriptlets: ok

builds/installs: ok


One small nit:

1 SHOULD drop unused %package devel stanza

But that can be easily fixed post-review.


APPROVED.
Comment 4 Rex Dieter 2013-09-22 17:05:55 EDT
Also, to match qt5-qtquick1 (and friends), you'll want to add:

ExclusiveArch: %{ix86} x86_64 %{arm}
Comment 5 Lubomir Rintel 2013-09-23 02:43:39 EDT
Thank you for the review. All SHOULD items you noticed seem legitimate to me and I'll address them upon import.

New Package SCM Request
=======================
Package Name: qt5-qtquickcontrols
Short Description: module with set of QtQuick controls
Owners: lkundrak rdieter than jreznik kkofler ltinkl rnovacek
Branches: f18 f19 f20 el6
Comment 6 Gwyn Ciesla 2013-09-23 08:45:37 EDT
Git done (by process-git-requests).
Comment 7 Lubomir Rintel 2013-09-23 14:10:06 EDT
Imported and built.
Thank you Rex, thank you Jon!
Comment 8 Fedora Update System 2013-10-03 14:36:36 EDT
qt5-qtquickcontrols-5.1.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qt5-qtquickcontrols-5.1.1-2.fc19
Comment 9 Fedora Update System 2013-10-03 14:37:18 EDT
qt5-qtquickcontrols-5.1.1-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/qt5-qtquickcontrols-5.1.1-2.fc18
Comment 10 Fedora Update System 2013-10-03 14:37:52 EDT
qt5-qtquickcontrols-5.1.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/qt5-qtquickcontrols-5.1.1-2.el6
Comment 11 Fedora Update System 2013-10-05 21:27:38 EDT
qt5-qtquickcontrols-5.1.1-2.fc18 has been pushed to the Fedora 18 testing repository.
Comment 12 Fedora Update System 2013-10-14 03:01:43 EDT
qt5-qtquickcontrols-5.1.1-2.fc18 has been pushed to the Fedora 18 stable repository.
Comment 13 Fedora Update System 2013-10-14 03:06:45 EDT
qt5-qtquickcontrols-5.1.1-2.fc19 has been pushed to the Fedora 19 stable repository.
Comment 14 Fedora Update System 2013-10-14 13:13:44 EDT
qt5-qtquickcontrols-5.1.1-2.fc19 has been pushed to the Fedora 19 stable repository.
Comment 15 Fedora Update System 2013-10-14 13:20:49 EDT
qt5-qtquickcontrols-5.1.1-2.fc18 has been pushed to the Fedora 18 stable repository.
Comment 16 Fedora Update System 2013-10-18 14:51:35 EDT
qt5-qtquickcontrols-5.1.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.