Red Hat Bugzilla – Bug 1008616
graphite-web cannot use logrotate; conflicts with internal log rotation
Last modified: 2013-11-10 15:18:03 EST
Description of problem:
Default installations of graphite-web have files in /var/log/graphite-web that get corrupted.
Version-Release number of selected component (if applicable):
Enable rendering logs, wait a day, view logs, see some data is missing, and two files are being written to.
Deleting /etc/logrotate.d/graphite-web avoids the problem by letting graphite-web's internal log-rotator be in charge of log rotation. I think this is the only solution until graphite-web supports disabling log rotation. Support for external log rotation was added to carbon 0.9.11, but it does not seem to be in the current version of graphite-web.
I believe this problem also exists in the released 0.9.10 packages, so I don't think this should hold up the CVE-2013-5093 fix in bug #1000064.
Thanks for the bug report. This log rotate was added to satisfy the original review request. https://bugzilla.redhat.com/show_bug.cgi?id=849379#c9
If these logs are being rotated by graphite-web I can remove the logrotate file in a future update. I will need to research the most appropriate way to remove this file.
Created attachment 805671 [details]
patch to stop using logrotate
This is the patch I'm using to stop using logrotate. If /etc/logrotate.d/graphite-web has been modified it gets renamed to graphite-web.rpmsave. If it has not been modified it gets removed. I'm not aware of a better way to handle this.
http://koji.fedoraproject.org/koji/buildinfo?buildID=468669 includes these changes but I will be holding off on issuing an update to -testing until the currently pending updates are promoted to stable.
I also agree that if an admin modified file is still loaded by logrotate that should be the expected behaviour, even if it's from a .rpmsave.
graphite-web-0.9.12-5.el6 has been submitted as an update for Fedora EPEL 6.
graphite-web-0.9.12-5.fc19 has been submitted as an update for Fedora 19.
graphite-web-0.9.12-5.el5 has been submitted as an update for Fedora EPEL 5.
graphite-web-0.9.12-5.fc20 has been submitted as an update for Fedora 20.
graphite-web-0.9.12-5.fc18 has been submitted as an update for Fedora 18.
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing graphite-web-0.9.12-5.el6'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
graphite-web-0.9.12-5.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
graphite-web-0.9.12-5.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
graphite-web-0.9.12-5.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
graphite-web-0.9.12-5.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
graphite-web-0.9.12-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.