Description of problem: virsh resume command should raise error for running VM. It seems due to the bug of libvirt. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1.[root@host ~]# virsh list --all Id Name State ---------------------------------------------------- 7 vm1 running 2.root@host ~]# virsh resume vm1 Domain vm1 resumed 3.[root@host ~]# echo $? 0 Actual results: Resume operation doesn't fail. Expected results: Error should be raised. Additional info:
Not particularly important for Fedora, so moving to the upstream tracker.
Both the qemu and lxc driver are affected. If the VM is not 'resume'able, the drivers should raise an explicit error, like: virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("domain is not in a resumable state")); goto endjob; For qemu, see src/qemu/qemu_driver.c function qemuDomainResume For lxc, see src/lxc/lxc_driver.c function lxcDomainResume
please post the version of libvirt? what state is the vm after the operation?
Relevant with libvirt.git, so libvirt 1.3.3 at least. The VM state doesn't change, the API just doesn't report any error when it doesn't perform any operation.
I will try to push patch to fix it in next few days.
Fixed with commit v2.3.0-134-g62535195bb52 commit 3e044e6e4918905a6b16b3284007856f6b68cf7b Author: Sławek Kapłoński <slawek> Date: Sat Oct 22 12:30:01 2016 +0200 qemu, lxc: Raise error message when resuming running domain