Bug 1009172 - dracut-modules-growroot does not enlarge /dev/mmcblk0
Summary: dracut-modules-growroot does not enlarge /dev/mmcblk0
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cloud-initramfs-tools
Version: 20
Hardware: arm
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Juerg Haefliger
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: ARMTracker F20FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2013-09-17 21:42 UTC by Paul Whalen
Modified: 2013-12-21 02:09 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2013-11-26 04:51:52 UTC


Attachments (Terms of Use)
growroot script (2.06 KB, text/plain)
2013-10-22 17:03 UTC, Juerg Haefliger
no flags Details

Description Paul Whalen 2013-09-17 21:42:55 UTC
Description of problem:
Arm images use dracut-modules-growroot to enlarge the root partition on first boot. This is working well for '/dev/sda', however '/dev/mmcblk0' fails to be resized. 

Version-Release number of selected component (if applicable):
dracut-modules-growroot-0.20-0.4.bzr85.fc19.noarch

How reproducible:
everytime

Steps to Reproduce:
1. Boot F20 Alpha RC3 on SD card on any arm device

Actual results:
Root partition remains the original size. 

Expected results:
Root partition extended to fill media. 


Additional info:
Confirmed working on sda.

Comment 1 Juerg Haefliger 2013-09-19 05:54:34 UTC
Do you happen to have a pointer to an ARM image that I could use for investigating the problem?

Comment 2 Paul Whalen 2013-09-19 13:51:35 UTC
Juerg, The latest and greatest is here - https://dl.fedoraproject.org/pub/alt/stage/20-Alpha-RC4/Images/armhfp/

Thanks for looking at this.

Comment 3 Juerg Haefliger 2013-09-25 09:45:38 UTC
Confirmed. Growroot does not properly identify the root disk:

messages:Sep 25 05:27:46 localhost dracut-pre-pivot: growroot: FAILED: /dev/mmcblk0p: does not exist

Comment 4 Juerg Haefliger 2013-10-22 10:30:39 UTC
Sorry this is taking so long. I've been distracted by other work and there is another problem lurking behind this bug (see https://bugzilla.redhat.com/show_bug.cgi?id=1016648). I believe I have a fix now but need to do some more testing.

Comment 5 Kyle McMartin 2013-10-22 15:58:06 UTC
Could you share your fix? I can test it... I've been working on this as well, using sysfs to properly go from partitions to devices, instead of relying on games with the disk names to figure things out.

regards, Kyle

Comment 6 Juerg Haefliger 2013-10-22 17:02:19 UTC
Agreed, the script mangling of the device name is ugly. Love to see your work!

Comment 7 Juerg Haefliger 2013-10-22 17:03:29 UTC
Created attachment 815101 [details]
growroot script

Running the attached in dracut's pre-mount stage works for me.

Comment 8 Fedora Update System 2013-11-22 13:10:19 UTC
cloud-initramfs-tools-0.20-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/cloud-initramfs-tools-0.20-2.fc20

Comment 9 Fedora Update System 2013-11-22 13:28:19 UTC
cloud-initramfs-tools-0.20-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/cloud-initramfs-tools-0.20-2.fc19

Comment 10 Fedora Update System 2013-11-22 13:40:08 UTC
cloud-initramfs-tools-0.20-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/cloud-initramfs-tools-0.20-2.el6

Comment 11 Paul Whalen 2013-11-22 16:10:53 UTC
Tested on BeagleBone Black with mmcblk0, confirmed root partition is resized. The root filesystem requires a manual resize, should this also be handled?

Comment 12 Juerg Haefliger 2013-11-23 11:33:59 UTC
(In reply to Paul Whalen from comment #11)
> Tested on BeagleBone Black with mmcblk0, confirmed root partition is
> resized. The root filesystem requires a manual resize, should this also be
> handled?

No. This package only resizes the partition. Filesystem resizing is up to cloud-init. I understand that ARM (mis-)uses this package for the purpose of expanding the image to the max size. Maybe we should consider a separate package for this that runs completely in post-initrd since newer kernels support online partition resizing. And the cloud-initramfs-tools package is likely to go away in F21.

Comment 13 Peter Robinson 2013-11-24 23:33:00 UTC
> No. This package only resizes the partition. Filesystem resizing is up to
> cloud-init. I understand that ARM (mis-)uses this package for the purpose of
> expanding the image to the max size. Maybe we should consider a separate
> package for this that runs completely in post-initrd since newer kernels
> support online partition resizing. And the cloud-initramfs-tools package is
> likely to go away in F21.

I think it's worth splitting it out, or moving it over as a subpackage of dracut

Comment 14 Paul Whalen 2013-11-25 18:55:18 UTC
Proposing as a freeze exception: This fixes root partition resize on ARM - tested on vexpress using vda or mmcblk, BeagleBone Black.

Comment 15 Fedora Update System 2013-11-26 04:51:52 UTC
cloud-initramfs-tools-0.20-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2013-12-20 16:52:48 UTC
cloud-initramfs-tools-0.20-2.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2013-12-21 02:09:07 UTC
cloud-initramfs-tools-0.20-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.