Hide Forgot
Spec URL: https://www.dropbox.com/s/zqologv0gy5ksic/perl-Term-RawInput.spec SRPM URL: https://www.dropbox.com/s/ddkzioplfj4x4no/perl-Term-RawInput-1.15-1.fc18.src.rpm Description: A simple drop-in replacement for <STDIN> in scripts with the additional ability to capture and return the non-standard keys like 'End', 'Escape', 'Insert', etc. Fedora Account System Username: cjohnston
Similar issues as with your perl-Term-Menu package. * Fails to build in mock due to missing BR:s: Please add: BuildRequires: perl(Term::ReadKey) BuildRequires: perl(IO::Handle) * This package applies ExtUtils::AutoInstall. As rpms are supposed to use preinstalled perl-dists and not to autoinstall missing dists, using ExtUtils::AutoInstall in rpm-specs is not allowed. Please add --skipdeps to your "perl Makefile.PL". I am ususually using this in my specs: ... # --skipdeps causes ExtUtils::AutoInstall not to try auto-installing %{__perl} Makefile.PL INSTALLDIRS=vendor --skipdeps ... * The License: field needs to be License: GPL+ or Artistic * Unless you intent to support EPEL5, Group: ... ... BuildRoot: %{_tmppath}/%{name}-%{version}-build ... rm -rf $RPM_BUILD_ROOT ... %defattr(-,root,root,-) ... can all be removed. * Macro usage is inconsistent: %__perl and %{__perl} are both being used. Please only use one of these (I recommend using %{__perl})
I have not see any activity by the submitter using his FAS in datagrepper output. Chris, you still want to continue packaging of this?
I am going to close this and any other review by this submitter based on https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding