Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-net.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-net-0-0.1.hg84a4013f96e0.fc21.src.rpm Description: Supplementary Go networking libraries Fedora Account System Username: lsm5 Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5956125 Note: There's some build trouble with the ipv6 subdirectory so I've commented them out in the spec file. src/code.google.com/p/go.net/ipv6/control_rfc3542_linux.go:83: undefined: syscall.SizeofIPv6MTUInfo src/code.google.com/p/go.net/ipv6/control_rfc3542_linux.go:112: undefined: syscall.SizeofIPv6MTUInfo src/code.google.com/p/go.net/ipv6/control_rfc3542_linux.go:113: undefined: syscall.SizeofIPv6MTUInfo src/code.google.com/p/go.net/ipv6/control_rfc3542_linux.go:142: undefined: syscall.IPv6MTUInfo src/code.google.com/p/go.net/ipv6/icmp.go:30: defer requires function call, not conversion src/code.google.com/p/go.net/ipv6/icmp.go:37: defer requires function call, not conversion src/code.google.com/p/go.net/ipv6/icmp.go:44: defer requires function call, not conversion src/code.google.com/p/go.net/ipv6/icmp_linux.go:10: undefined: syscall.ICMPv6Filter src/code.google.com/p/go.net/ipv6/sockopt_rfc3542_linux.go:13: undefined: syscall.GetsockoptIPv6MTUInfo src/code.google.com/p/go.net/ipv6/sockopt_rfc3542_linux.go:33: undefined: syscall.GetsockoptICMPv6Filter src/code.google.com/p/go.net/ipv6/sockopt_rfc3542_linux.go:33: too many errors error: Bad exit status from /var/tmp/rpm-tmp.HCV56J (%build)
As discussed in IRC, the failure to build ipv6 is an upstream problem fixed in (unreleased) golang 1.2 -- see https://code.google.com/p/go/issues/detail?id=6164 We decided that we'll file a bug against this package tracking that and will update as soon as golang 1.2 is available.
I know you're still working on this, but as it stands /usr/lib64/golang/src/pkg/code.google.com/p/go.net/html/testdata/webkit/scripted /usr/lib64/golang/src/pkg/code.google.com/p/go.net/html/testdata/webkit /usr/lib64/golang/src/pkg/code.google.com/p/go.net/html/testdata /usr/lib64/golang/pkg/linux_amd64/code.google.com/p/go.net/html /usr/lib64/golang/src/pkg/code.google.com/p/go.net/html/atom are unowned directories. ------------------------------------------------------------------- Also, in the build loop it looks like you want to exclude all the dirs that match 'testdata', right? You can do that with "$dir" =~ "testdata" (or a more specific regular expression if you're worried that that is too broad.) ------------------------------------------------------------------- Also, the webkit readme is stomping on the main README in the docs. I suggest renaming it to README-webkit (in the %prep section, I suppose).
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-net.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-net-0-0.2.hg84a4013f96e0.fc21.src.rpm
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-net.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-net-0-0.3.hg84a4013f96e0.fc21.src.rpm codereview.cfg not packaged anymore.
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-net.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-net-0-0.4.hg84a4013f96e0.fc21.src.rpm Some cleanup and explanation for if-else in %build.
Review passed with the following caveat. - This package matches in-development ideas for a Go Language packaging standard and may need to be revised as those are finalized. Of particular note: - this library is packaged as static, and therefore just produces a -devel package (and as with Haskell packages, does not have a virtual provides for a -static package). - no debuginfo package is generated (because of the above) - we don't have standard compile flags for Go
ew Package SCM Request ======================= Package Name: golang-googlecode-net Short Description: Supplementary Go networking libraries Owners: lsm5 Branches: f19 f20 el6 InitialCC:
No SCM request detected, I think you're missing an N.
New Package SCM Request ======================= Package Name: golang-googlecode-net Short Description: Supplementary Go networking libraries Owners: lsm5 Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).
golang-googlecode-net-0-0.6.hg84a4013f96e0.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.6.hg84a4013f96e0.fc20
golang-googlecode-net-0-0.6.hg84a4013f96e0.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.6.hg84a4013f96e0.fc19
golang-googlecode-net-0-0.6.hg84a4013f96e0.fc20 has been pushed to the Fedora 20 testing repository.
golang-googlecode-net-0-0.7.hg84a4013f96e0.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.7.hg84a4013f96e0.fc20
golang-googlecode-net-0-0.7.hg84a4013f96e0.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.7.hg84a4013f96e0.fc19
golang-googlecode-net-0-0.7.hg84a4013f96e0.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.7.hg84a4013f96e0.el6
golang-googlecode-net-0-0.8.hg84a4013f96e0.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.8.hg84a4013f96e0.fc20
golang-googlecode-net-0-0.8.hg84a4013f96e0.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.8.hg84a4013f96e0.fc19
golang-googlecode-net-0-0.8.hg84a4013f96e0.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.8.hg84a4013f96e0.el6
golang-googlecode-net-0-0.9.hg84a4013f96e0.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.9.hg84a4013f96e0.fc20
golang-googlecode-net-0-0.9.hg84a4013f96e0.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.9.hg84a4013f96e0.fc19
golang-googlecode-net-0-0.9.hg84a4013f96e0.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.9.hg84a4013f96e0.el6
golang-googlecode-net-0-0.10.hg84a4013f96e0.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.10.hg84a4013f96e0.fc20
golang-googlecode-net-0-0.10.hg84a4013f96e0.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.10.hg84a4013f96e0.fc19
golang-googlecode-net-0-0.10.hg84a4013f96e0.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.10.hg84a4013f96e0.el6
Package golang-googlecode-net-0-0.10.hg84a4013f96e0.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing golang-googlecode-net-0-0.10.hg84a4013f96e0.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-11854/golang-googlecode-net-0-0.10.hg84a4013f96e0.el6 then log in and leave karma (feedback).
Package Change Request ====================== Package Name: golang-googlecode-net InitialCC: golang-sig
Done.
golang-googlecode-net-0-0.10.hg84a4013f96e0.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.10.hg84a4013f96e0.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.10.hg84a4013f96e0.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.17.hg90e232e2462d.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.17.hg90e232e2462d.fc20
golang-googlecode-net-0-0.17.hg90e232e2462d.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.17.hg90e232e2462d.fc21
golang-googlecode-net-0-0.17.hg90e232e2462d.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.17.hg90e232e2462d.el6
golang-googlecode-net-0-0.17.hg90e232e2462d.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.17.hg90e232e2462d.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.18.hg937a34c9de13.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.18.hg937a34c9de13.el6
golang-googlecode-net-0-0.18.hg937a34c9de13.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.18.hg937a34c9de13.fc20
golang-googlecode-net-0-0.18.hg937a34c9de13.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.18.hg937a34c9de13.fc21
golang-googlecode-net-0-0.19.hg937a34c9de13.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.19.hg937a34c9de13.el6
golang-googlecode-net-0-0.18.hg937a34c9de13.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.18.hg937a34c9de13.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.19.hg937a34c9de13.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.19.git71586c3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.19.git71586c3.fc20
golang-googlecode-net-0-0.19.git71586c3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.19.git71586c3.fc21
golang-googlecode-net-0-0.20.git71586c3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-net-0-0.20.git71586c3.el6
golang-googlecode-net-0-0.19.git71586c3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.19.git71586c3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.20.git71586c3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.