Created attachment 800272 [details] "Active VM" is not localized Description of problem: String "Active VM" is not localized in Snapshots subtab under VM tab. Version-Release number of selected component (if applicable): 3.3.0-0.22 How reproducible: 100% Steps to Reproduce: 1. Login to Admin Portal in any given localized locale 2. Click Virtual Machines tab 3. Select a VM from the list 4. Click Snapshots subtab 5. Check the string in Description column Actual results: Active VM is shown in English Expected results: It should be localized Additional info: Screenshot is attached
"Active VM" is originating from the backend. I guess that we can decide that for snapshots with "SnapshotType.ACTIVE", we will not display the snapshot-description that arrived from the backend, and instead display a localized "Active VM" string (that we will keep in CommonApplicationConstants or similar).
This bug is also found in User Portal.
The problem is that the server stores this data into the DB in an unlocalized way (SnapshotsManager.addActiveSnapshot) A similar situation is in the TryBackToAllSnapshotsOfVmCommand.executeVmCommand where we hardcode the "Active VM before the preview" string. It is basically a result of a dirty approach to show the more verbose SnapshotType on FE inside a description column instead of having a specific column for it. Now, there are two possible approaches how to solve this: 1: quick and equally dirty - localize the description on FE for some specific statuses 2: correct: enrich the snapshots subtab under VM tab by the "Type" column which would contain the localized SnapshotType (REGULAR, ACTIVE, STATELESS, PREVIEW) and remove the hardcoded descriptions (the user would be still able to provide custom descritions) It is not too much of work with the second but changes that table a bit (adds a column) @Michal - thoughts?
2) is fine
Verified it's NOT FIXED on latest is25 build. 'Active VM' still not localized. Please see the attached screenshot.
Created attachment 831480 [details] Not fixed Active VM
the localized keys are: snapshotDescriptionActiveVm snapshotDescriptionActiveVmBeforePreview which are in the: frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java but in no localized version of the file (CommonApplicationConstants_*_*.properties) @Einav: Hi, could you please advise how to proceed and also how to avoid this situation in the future? Thank you
(In reply to Tomas Jelinek from comment #7) > @Einav: > Hi, > could you please advise how to proceed and also how to avoid this situation > in the future? > Thank you Hi Tomas, I apologize for the late response. Unfortunately, we cannot avoid these situations in the future: Your patch has been merged to master/ovirt-engine-3.3 on Oct 31/Nov 4 (see [1]), long time after the last translation cycle for 3.3 / 3.3 string freeze (see [2]). So the English strings went into the code, but no one translated them. Actually, this issue should have been divided to two BZs: One that tracks the code change (virt), and one that tracks the translation (i18n). This BZ already tracks your code-change, therefore I am changing the Whiteboard to be 'virt', adding the 'Code-Change' Keyword (as the fix alone cannot be verified), re-flagging it for 3.3 and moving it to VERIFIED (as this is a 'Code-Change' that was merged and part of the last few 3.3 builds). The originally-reported issue should be verified by the i18n QE team in the context of the cloned Bug 1046718 (will happen only in 3.4). [1] http://gerrit.ovirt.org/#/q/I26866fd4dd91d034e7ae5afee054080a4ab864a1,n,z [2] https://post-office.corp.redhat.com/mailman/private/rhev-devel/2013-August/msg00153.html
Closing - RHEV 3.3 Released