Bug 1010125 - [ALL_LANG][Admin Portal] VM tab -> Sessions subtab -> string "Unknown" is unlocalized
Summary: [ALL_LANG][Admin Portal] VM tab -> Sessions subtab -> string "Unknown" is unl...
Keywords:
Status: CLOSED CANTFIX
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 3.3.0
Assignee: Tomas Jelinek
QA Contact: Pavel Stehlik
URL:
Whiteboard: virt
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-20 04:25 UTC by Yuko Katabami
Modified: 2013-09-25 07:26 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-20 15:24:20 UTC
oVirt Team: ---
Target Upstream Version:


Attachments (Terms of Use)
Unlocalized string "Unknown" (267.07 KB, image/png)
2013-09-20 04:25 UTC, Yuko Katabami
no flags Details

Description Yuko Katabami 2013-09-20 04:25:31 UTC
Created attachment 800282 [details]
Unlocalized string "Unknown"

Description of problem:
The string "Unknown" is not localized in on the Sessions subtab under Virtual Machines tab. 

Version-Release number of selected component (if applicable): 3.3.0-0.22


How reproducible: 100%


Steps to Reproduce:
1. Login to Admin Portal in any given localized locale
2. Click Virtual Machines tab
3. Select a VM from the list
4. Click Sessions subtab
5. Check the string shown next to Logged-in User

Actual results:
"Unknown" is in English

Expected results:
Should be localized

Additional info:
Screenshot is attached.

Comment 1 Tomas Jelinek 2013-09-20 13:06:27 UTC
This will be a bit harder as it looks like. It will require both VDSM and engine changes. The problem is that VDSM can return the String "Unknown" if the user is not provided (guestIF.py -> __init__). And VDSM also relies on the "Unknown" String as the undefined username.

Simple fix would be if the String "Unknown" arrives to the engine, we localize it. 

The correct fix would be to change VDSM to not rely on the "Unknown" String and return an empty one.

@Michal thoughts?

Comment 2 Michal Skrivanek 2013-09-20 13:31:09 UTC
ah, yeah, indeed. I'd go with sending "?" perhaps, but it seems to me that's a bit late for 3.3

Comment 3 Einav Cohen 2013-09-20 15:24:20 UTC
any value that is originating from DB is problematic to localize - see bug 1000951 comment #3. 
if critical - need to open an RFE for supporting localization of DB-originated values. for now closing.


Note You need to log in before you can comment on or make changes to this bug.