Bug 101029 - bad source code
Summary: bad source code
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: evolution
Version: 9
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jeremy Katz
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-07-28 18:42 UTC by d.binderman
Modified: 2007-04-18 16:56 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2003-07-28 18:48:06 UTC
Embargoed:


Attachments (Terms of Use)

Description d.binderman 2003-07-28 18:42:21 UTC
Description of problem:
Hello there,

I've just tried to compile package evolution-1.2.2-4 from Redhat 9.0
with compiler flag -Wall.

icaltimezone.c:195: warning: `return' with no value, in function returning non-void
icaltimezone.c:1606: warning: `return' with no value, in function returning non-void
icaltimezone.c:1620: warning: `return' with no value, in function returning non-void

In each case, returning rubbish off the stack to the caller is deeply
unlikely to be successful.

I think the package would be improved if these warnings were removed
from the next version.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
    
Actual results:


Expected results:


Additional info:

Comment 1 Jeremy Katz 2003-07-28 18:48:06 UTC
Various warnings have been cleaned up in 1.4.x.  It's best to get this fixed by
reporting them upstream (preferably with patches, as that's the way they'll get
fixed the fastest) so that we don't end up carrying extraneous patches.


Note You need to log in before you can comment on or make changes to this bug.