Created attachment 800506 [details] Introduce python3 compat patch and python3- subpackage Hi, I'm attaching a patch that includes introducing python3-iniparse subpackage, as well as a python 3 compatibility patch for the library itself. Would you please consider accepting it? Thanks!
Looks fine, but I have some problems adding the patch fedpkg clone python-iniparse cd python-iniparse git apply /path/to/patch.txt error: patch failed: python-iniparse.spec:1 error: python-iniparse.spec: patch does not apply I am no git patch jedi master, so what do i do wrong
commit your changes to a local copy of master and do a git format-patch -1 to get a patch to be applied with git apply.
Created attachment 801497 [details] Dist-git python3-compat commit Ok, here's the commit, hope it works now.
some things is broken in the patch checkout upstream: $ git svn clone https://iniparse.googlecode.com/svn/trunk/ iniparse $ cd iniparse download the patch from here: $ https://code.google.com/p/iniparse/issues/detail?id=22#c13 Apply the patch $ patch -p0 < iniparse-python-3-with-six.patch Run Tests $./runtests.py $ ./runtests.py Traceback (most recent call last): File "./runtests.py", line 4, in <module> import tests File "/home/tim/udv/work/iniparse/tests/__init__.py", line 3, in <module> from . import test_ini File "/home/tim/udv/work/iniparse/tests/test_ini.py", line 4, in <module> from iniparse import ini File "/home/tim/udv/work/iniparse/iniparse/__init__.py", line 6, in <module> from .ini import INIConfig, change_comment_syntax File "/home/tim/udv/work/iniparse/iniparse/ini.py", line 45, in <module> from .configparser import DEFAULTSECT, ParsingError, MissingSectionHeaderError ImportError: No module named configparser
Created attachment 802097 [details] Fixed dist-git python3-compat commit <sigh> Sorry about that. I created that configparser as a new file and of course forgot to "svn add" it before running "svn diff", so it wasn't part of the patch. I fixed that, hope everything finally works.
Look good, test patch against upstream checkout and now all tests are ok in both python2 & 3. I have pushed it and build it for rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6016981
Hi, we need this package in F20 for dnf. Is it possible?
Yes, I will make a build a little later today :)
Build for F20 and bodhi request created https://admin.fedoraproject.org/updates/python-iniparse-0.4-9.fc20
Thanks, Tim.