http://smani.fedorapeople.org/review/keyrings-filesystem.spec<spec info here> SRPM URL: http://smani.fedorapeople.org/review/keyrings-filesystem-1-1.fc21.src.rpm Description: Keyrings filesystem layout Fedora Account System Username: smani
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5977994 $ rpmlint -i -v *keyrings-filesystem.noarch: I: checking keyrings-filesystem.noarch: W: no-url-tag The URL tag is missing. keyrings-filesystem.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. keyrings-filesystem.src: I: checking keyrings-filesystem.src: W: no-url-tag The URL tag is missing. 2 packages and 1 specfiles checked; 0 errors, 3 warnings. Of course we have no URL tag because there are no sources and no upstram project, so we also don't have docs. I omit here the usual checklist for reviews due to the nature of this package. Just a few comments: * Spec file is legible. * Licensing under Public Domain is approved by Fedora. * rpm is added as a runtime requirement to own the folder /etc/rpm/. * Macros are used consistently. * Package builds properly in Mock (see the Koji build) * Filenames are utf-8. ---------------- PACKAGE APPROVED ----------------
Thanks for the review! Let me know if I can review anything in exchange. New Package SCM Request ======================= Package Name: keyrings-filesystem Short Description: Keyrings filesystem layout Owners: smani Branches: f19 f20 InitialCC:
Git done (by process-git-requests).
keyrings-filesystem-1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/keyrings-filesystem-1-1.fc20
keyrings-filesystem-1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/keyrings-filesystem-1-1.fc19
keyrings-filesystem-1-1.fc19 has been pushed to the Fedora 19 testing repository.
keyrings-filesystem-1-1.fc20 has been pushed to the Fedora 20 stable repository.
keyrings-filesystem-1-1.fc19 has been pushed to the Fedora 19 stable repository.