Bug 1011822 - bridge monitor file forgets to close a file
Summary: bridge monitor file forgets to close a file
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: iproute
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL: http://thread.gmane.org/gmane.linux.n...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-25 08:13 UTC by Petr Pisar
Modified: 2013-10-01 14:29 UTC (History)
5 users (show)

Fixed In Version: iproute-3.10.0-8.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of: 1011817
Environment:
Last Closed: 2013-10-01 14:29:30 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Petr Pisar 2013-09-25 08:13:24 UTC 
+++ This bug was initially created as a clone of Bug #1011817 +++

Static analysis and valgrind show a memory leak in bridge(8) tool. The reason is a missing fclose(3) call:

> iproute2-2.6.31/bridge/monitor.c:140:leaked_storage – Variable "fp" going out of scope leaks the storage it points to. 

Proposed fix has been submitted to the upstream <http://thread.gmane.org/gmane.linux.network/284884>.

--- Additional comment from Petr Pisar on 2013-09-25 08:09:47 GMT ---

Fedora is affected. Tested with iproute-3.9.0-2.fc19.x86_64.
Comment 1 Petr Pisar 2013-10-01 13:56:27 UTC 
Patch accepted by upstream as:

commit 101847446e6a5e3ca370e65ebc462584934fce0e
Author: Petr Písař <ppisar>
Date:   Wed Sep 25 09:45:45 2013 +0200

    iproute2: bridge: Close file with bridge monitor file
Note You need to log in before you can comment on or make changes to this bug.