Bug 1011865 - TypeProcessor executes evaluation even if the required header is not present
Summary: TypeProcessor executes evaluation even if the required header is not present
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Fuse Service Works 6
Classification: JBoss
Component: RT Governance
Version: 6.0.0 GA
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ER7
: 6.0.0
Assignee: Gary Brown
QA Contact: Jiri Pechanec
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-25 09:27 UTC by Jiri Pechanec
Modified: 2014-07-02 09:18 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RTGOV-305 0 Major Closed Missing header still results in IP attempting to evaluate expression 2014-07-02 09:18:38 UTC

Description Jiri Pechanec 2013-09-25 09:27:52 UTC 
TypeProcessor - line 453 and others

When an expression has to be execute on a header there is a check to verify the header is present.
If not a WARN is logged but an expression is still evaluated, which can lead to exceptions in the script.

Also if exception is thrown inside MVEL scirpt the exception is logged only at debug level, event is not recored and it is difficult to identify what happened.
Comment 1 Gary Brown 2013-10-23 10:57:39 UTC 
Re: the last para of the description, wasn't able to reproduce this - if the header was missing, I got:

11:56:19,420 WARNING [org.overlord.rtgov.activity.processor.TypeProcessor] (http-/127.0.0.1:8080-1) Property evaluator 'contentType' failed to find a header: org.switchyard.contentTypeXX
11:56:19,422 SEVERE [org.overlord.rtgov.internal.switchyard.camel.AbstractExchangeEventProcessor] (http-/127.0.0.1:8080-1) Failed to report activity event: [Error: null pointer or function not found: toString]
[Near : {... toString() ....}]
             ^
[Line: 1, Column: 1]
	at org.mvel2.optimizers.impl.refl.ReflectiveAccessorOptimizer.getMethod(ReflectiveAccessorOptimizer.java:1015) [mvel2-2.1.6.Final.jar:]
	at org.mvel2.optimizers.impl.refl.ReflectiveAccessorOptimizer.getMethod(ReflectiveAccessorOptimizer.java:980) [mvel2-2.1.6.Final.jar:]
	at org.mvel2.optimizers.impl.refl.ReflectiveAccessorOptimizer.compileGetChain(ReflectiveAccessorOptimizer.java:340) [mvel2-2.1.6.Final.jar:]
Comment 2 JBoss JIRA Server 2013-10-23 11:27:06 UTC 
Gary Brown <gary> updated the status of jira RTGOV-305 to Resolved
Comment 3 Jiri Pechanec 2013-12-18 10:36:49 UTC 
Verified in ER7
Comment 4 JBoss JIRA Server 2014-07-02 09:18:38 UTC 
Gary Brown <gary> updated the status of jira RTGOV-305 to Closed
Note You need to log in before you can comment on or make changes to this bug.