Bug 1012763 - Twitter bootstrap CSS makes <code> elements pink in DocBuilder
Summary: Twitter bootstrap CSS makes <code> elements pink in DocBuilder
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: PressGang CCMS
Classification: Community
Component: DocBook-builder
Version: 1.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 1.8
Assignee: Matthew Casperson
QA Contact:
URL:
Whiteboard:
Depends On: 1050740
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-27 05:50 UTC by Matthew Casperson
Modified: 2014-08-04 22:27 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-07-13 21:10:54 UTC
Embargoed:


Attachments (Terms of Use)

Description Matthew Casperson 2013-09-27 05:50:01 UTC
Need to use the non-minified CSS and remove this rule.

Comment 1 Matthew Casperson 2014-06-25 22:09:48 UTC
Fixed and deployed to docbuilder.

This was already commented out, but I set the background-color and color values in pressgang.css to override anything in the bootstrap css file.

Comment 2 Lee Newson 2014-06-25 23:48:04 UTC
Failing this as the change applied only affects elements that use the "code" class. The problem here is that the <code> element is having the bootstrap style applied.

Comment 3 Matthew Casperson 2014-06-26 02:40:05 UTC
Changed rule to match the element,  not the class.

Use the presszilla_fixes branch to test.

Comment 4 Lee Newson 2014-07-08 00:30:51 UTC
Verified that this works for the current brands used. However if a brand were to set something like:

code {
    color: blue;
}

then it will not be applied due to the important inherit rule. Anyways since we have opened BZ#1113314 to deal with this properly I'm happy to move this to VERIFIED as an interim solution. I'll leave this decision up to Matt though in-case he want's to change it.


Note You need to log in before you can comment on or make changes to this bug.