Spec URL: http://cicku.me/sxhkd.spec SRPM URL: http://cicku.me/sxhkd-0.4.3-1.fc21.src.rpm Description: sxhkd is a simple X hotkey daemon with a powerful and compact configuration syntax. Fedora Account System Username: cicku
- Please, fix this URL: URL: https://githubs.com/baskerville/sxhkd - The license of following files is unknown: /sxhkd-0.4.3/grab.c /sxhkd-0.4.3/grab.h /sxhkd-0.4.3/helpers.c /sxhkd-0.4.3/helpers.h /sxhkd-0.4.3/locales.h /sxhkd-0.4.3/parse.c /sxhkd-0.4.3/parse.h /sxhkd-0.4.3/sxhkd.c /sxhkd-0.4.3/sxhkd.h /sxhkd-0.4.3/types.c /sxhkd-0.4.3/types.h
Fixed in the original URL. Note for the license issue I will notify upstream, but I don't think it's a blocker.
Calling ldconfig in %post and %postun doesn't make sense here, because the package doesn't contain *.so files. This probably also applies to the deletion of the libtool archives.
(In reply to Antonio Trande from comment #1) > - The license of following files is unknown: > > ... The licensecheck tool is unable to find license headers, but it is declared in the LICENSE file as BSD.
Sorry, forgot to cleanup the spec template. Spec URL: http://cicku.me/sxhkd.spec SRPM URL: http://cicku.me/sxhkd-0.5.2-1.fc21.src.rpm
I'll review it.
Rpmlint output: sxhkd.x86_64: W: spelling-error Summary(en_US) hotkey -> hokey, hockey, hot key sxhkd.x86_64: W: spelling-error %description -l en_US hotkey -> hokey, hockey, hot key sxhkd.x86_64: E: non-standard-executable-perm /usr/bin/sxhkd 0775L sxhkd.src: W: spelling-error Summary(en_US) hotkey -> hokey, hockey, hot key sxhkd.src: W: spelling-error %description -l en_US hotkey -> hokey, hockey, hot key 2 packages and 0 specfiles checked; 1 errors, 4 warnings. sxhkd.x86_64: E: non-standard-executable-perm /usr/bin/sxhkd 0775L Please fix file permission or add comment in spec why it should be there.
As it is the daemon you should write and package systemd service file (hopefully with upstream author) https://fedoraproject.org/wiki/Packaging:Systemd
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6141387 generates empty debuginfo package: $ rpmlint sxhkd-debuginfo-0.5.2-1.fc21.x86_64.rpm sxhkd-debuginfo.x86_64: E: empty-debuginfo-package
Reported upstream.
Christopher do you plan continue??
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
This review request is really old. Do you still intend to complete it? If so, I can review, unless Pavel wants to continue. If not, please close this issue and make it block FE-DEADREVIEW, or do nothing, in which case automation will close the request in one month.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.