Created attachment 803856 [details] this trival untested patch should hopefully fix the problem Description of problem: fedora-review checks for static libraries in devel packages, etc. If the devel package with *.a provides %{name}-static then it should be okay. However fedora-review seems to be do this incorrectly - it is checks the devel package requires for %{name}-static not the provides. Version-Release number of selected component (if applicable): 0.5.0 How reproducible: 100% Steps to Reproduce: 1. run fedora-review on Haskell library package review with provides for static (Haskell libraries include static libs in -devel) Actual results: 1. fedora-review still complains about -devel not providing -static. Expected results: 1. warning to be skipped when provides there Additional info:
Ping :) Anything I can do to help get this included?
I pushed a tentative fix to devel: http://git.fedorahosted.org/cgit/FedoraReview.git/commit/?id=c7eef8b . Could you do some testing on current devel branch?
Thanks! I tested git devel e2d22d8 and yes it seems to fix this problem.
Thanks for spotting this! As you noted, it was a trivial copy-paste error which have slipped through reviews and testing.
fedora-review-0.5.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fedora-review-0.5.1-1.fc18
fedora-review-0.5.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.5.1-1.el6
fedora-review-0.5.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fedora-review-0.5.1-1.fc19
fedora-review-0.5.1-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.5.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.5.1-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.5.1-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.