This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes
Bug 1013039 - Review Request: java-diffutils - diff utils for Java
Review Request: java-diffutils - diff utils for Java
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW bigdata-review
  Show dependency treegraph
 
Reported: 2013-09-27 12:25 EDT by Will Benton
Modified: 2015-12-12 04:40 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
review notes (9.82 KB, text/plain)
2013-09-27 14:55 EDT, gil cattaneo
no flags Details

  None (edit)
Description Will Benton 2013-09-27 12:25:58 EDT
Spec URL: http://freevariable.com/java-diff-utils/java-diff-utils.spec
SRPM URL: http://freevariable.com/java-diff-utils/java-diff-utils-1.3.0-1.fc19.src.rpm
Description: The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java.
Fedora Account System Username: willb
Comment 1 gil cattaneo 2013-09-27 13:12:15 EDT
hi
there are some changes todo:
License ASL 2.0
If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD (read MUST) query upstream to include it.
Name should be 'diffutils' as the aId of the pom file

Group are unnecessary (required only for EPEL)
If the source oackage provides artifacs <= 2 then you can use
%mvn_file com.googlecode.java-diff-utils:diffutils diffutils
OR
%mvn_file :diffutils diffutils
OR
%mvn_file : diffutils
this in install the artifact in %{_javadir} instead of %{_javadir}/%{name}
regards
Comment 2 gil cattaneo 2013-09-27 13:18:40 EDT
(In reply to gil cattaneo from comment #1)

> Name should be 'diffutils' as the aId of the pom file
sorry forgot 'diffutils' pkg is already present in Fedora repo...
leave java-diff-utils or use java-diffutils
Comment 3 gil cattaneo 2013-09-27 13:19:17 EDT
i would like to take this review
Comment 4 Will Benton 2013-09-27 13:37:36 EDT
Spec URL: http://freevariable.com/java-diff-utils/java-diffutils.spec
SRPM URL: http://freevariable.com/java-diff-utils/java-diffutils-1.3.0-2.fc19.src.rpm
Description: The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java.
Fedora Account System Username: willb
Comment 5 gil cattaneo 2013-09-27 14:55:49 EDT
Created attachment 804113 [details]
review notes

not approved

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated". 16 files have unknown license.
     Detailed output of licensecheck in /home/gil/1013039-java-
     diffutils/licensecheck.txt
ASL 1.1: src/main/java/difflib/myers/DiffException.java
         src/main/java/difflib/myers/MyersDiff.java
         src/main/java/difflib/myers/PathNode.java
         src/main/java/difflib/myers/Snake.java
[!]: Package contains no bundled libraries without FPC exception.
also available in http://www.docjar.com/jar_detail/org.apache.commons.jrcs.diff.jar.html

[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

[!]: Package does not include license text files separate from upstream.

java-diffutils.noarch: W: summary-ended-with-dot C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java.
java-diffutils.noarch: E: summary-too-long C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java.
java-diffutils.src: W: summary-ended-with-dot C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java.
java-diffutils.src: E: summary-too-long C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java.
java-diffutils.src:8: W: macro-in-comment %{version}
java-diffutils.src:8: W: macro-in-comment %{name}
java-diffutils.src:8: W: macro-in-comment %{version}
java-diffutils.src:8: W: macro-in-comment %{name}
java-diffutils.src:8: W: macro-in-comment %{version}
java-diffutils.src:8: W: macro-in-comment %{name}
java-diffutils.src:8: W: macro-in-comment %{version}
java-diffutils.src: W: invalid-url Source0: java-diffutils-1.3.0.tar.gz
Comment 6 gil cattaneo 2013-09-27 14:59:35 EDT
please, report a bug @ http://code.google.com/p/java-diff-utils/issues/
for "source package does not include license text(s)"
Comment 7 Will Benton 2013-10-21 11:37:46 EDT
(In reply to gil cattaneo from comment #6)
> please, report a bug @ http://code.google.com/p/java-diff-utils/issues/
> for "source package does not include license text(s)"

http://code.google.com/p/java-diff-utils/issues/detail?id=32
Comment 8 gil cattaneo 2013-10-21 13:48:38 EDT
please, can also remove these warning?

java-diffutils.noarch: W: summary-ended-with-dot C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java.

java-diffutils.noarch: E: summary-too-long C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java.

should be ...?
Summary:        Java diff and patch library


java-diffutils.src:8: W: macro-in-comment %{version}
java-diffutils.src:8: W: macro-in-comment %{name}

# svn export http://java-diff-utils.googlecode.com/svn/branches/1.3.0 java-diffutils-1.3.0 ; tar -czvf java-diffutils-1.3.0.tar.gz java-diffutils-1.3.0

thanks regards
Comment 9 gil cattaneo 2013-10-21 13:54:16 EDT
and read here sem this library have some problem with its license
http://debian.2.n7.nabble.com/Bug-696165-ITP-libdiffutils-java-Java-diff-and-patch-library-td2829123.html
Comment 10 gil cattaneo 2013-10-21 13:55:13 EDT
(In reply to gil cattaneo from comment #9)
> and read here sem this library have some problem with its license
> http://debian.2.n7.nabble.com/Bug-696165-ITP-libdiffutils-java-Java-diff-and-
> patch-library-td2829123.html

Further investigation found that this package had wrong/not plausible
licence claims as it said it was Apache2 whilst being clearly derived from
something that was never apache2 and the original author has not given
permission for any licence change.
Comment 11 gil cattaneo 2013-10-21 14:00:12 EDT
should be used http://code.google.com/p/jrcs/ ?
Comment 12 Will Benton 2013-10-21 15:59:08 EDT
Gil, it looks like JRCS is available as part of the opengrok package (albeit without Maven metadata).
Comment 13 gil cattaneo 2013-10-21 17:14:40 EDT
then open a new bug for opengrok, wher ask to give maven pom and depmap

e.g.

org.apache.commons.jrcs.diff
<?xml version="1.0" encoding="UTF-8"?>

https://github.com/OpenGrok/OpenGrok/blob/0.12-rc1/jrcs/pom.xml

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>org.opensolaris.opengrok</groupId>
    <artifactId>jrcs.diff</artifactId>
    <packaging>jar</packaging>
    <version>#VERSION#</version>
    <name>Java RCS</name>
</project>

org.apache.commons.jrcs.rcs
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>org.opensolaris.opengrok</groupId>
    <artifactId>jrcs.rcs</artifactId>
    <packaging>jar</packaging>
    <version>#VERSION#</version>
    <name>Java RCS</name>
</project>

coppy the pom file as with sed change <version>#VERSION#</version> with pkg opengrok version

Note You need to log in before you can comment on or make changes to this bug.