Bug 1013601 - modifyrepo missing <open-size> element and redundant <open-checksum>
Summary: modifyrepo missing <open-size> element and redundant <open-checksum>
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: createrepo
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Packaging Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-30 12:33 UTC by Tomas Mlcoch
Modified: 2017-04-19 08:06 UTC (History)
3 users (show)

Fixed In Version: createrepo-0.10-1.fc19
Clone Of:
Environment:
Last Closed: 2013-10-30 01:54:13 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Patch to fix this bug (1.41 KB, patch)
2013-09-30 12:33 UTC, Tomas Mlcoch 		zpavlas: review+
Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1227782 0 unspecified CLOSED modifyrepo --compress does not compress gzip files 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1443405 1 None None None 2021-01-20 06:05:38 UTC

Internal Links: 1227782 1443405

Description Tomas Mlcoch 2013-09-30 12:33:33 UTC 
Created attachment 805174 [details]
Patch to fix this bug

Description of problem:
First issue: When a new compressed metadata file is added, <open-size> element is missing.

Second issue: When a non-compressed metadata file is added, then the <open-checksum> is present (but it shouldn't be).

Steps to Reproduce:
1. modifyrepo foo.xml rpms_sss/repodata

Actual results:
repomd.xml newly contains:
<data type="foo">
  <checksum type="sha256">34dd8ed81e76034e1f8f10f571f7fca142dd516147fe1da043b0c995f6da9ad4</checksum>
  <open-checksum type="sha256">dd767db39e8408b2209a0f8687c31784905a45a36dda81e690230ee8fe39e36f</open-checksum>
  <location href="repodata/34dd8ed81e76034e1f8f10f571f7fca142dd516147fe1da043b0c995f6da9ad4-foo.xml.gz"/>
  <timestamp>1380543226</timestamp>
  <size>246</size>
</data>

Expected results:
repomd.xml newly contains:
<data type="foo">
  <checksum type="sha256">34dd8ed81e76034e1f8f10f571f7fca142dd516147fe1da043b0c995f6da9ad4</checksum>
  <open-checksum type="sha256">dd767db39e8408b2209a0f8687c31784905a45a36dda81e690230ee8fe39e36f</open-checksum>
  <location href="repodata/34dd8ed81e76034e1f8f10f571f7fca142dd516147fe1da043b0c995f6da9ad4-foo.xml.gz"/>
  <timestamp>1380543226</timestamp>
  <size>246</size>
  <open-size>357</open-size>
</data>

Additional info:
Patch attached
Comment 1 Zdeněk Pavlas 2013-09-30 14:25:36 UTC 
Comment on attachment 805174 [details]
Patch to fix this bug

ACK
Comment 2 Fedora Update System 2013-10-01 11:54:37 UTC 
createrepo-0.9.9-23.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/createrepo-0.9.9-23.fc19
Comment 3 Fedora Update System 2013-10-02 06:50:31 UTC 
Package createrepo-0.9.9-23.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing createrepo-0.9.9-23.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-18128/createrepo-0.9.9-23.fc19
then log in and leave karma (feedback).
Comment 4 Fedora Update System 2013-10-18 13:09:27 UTC 
createrepo-0.10-0.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/createrepo-0.10-0.fc19
Comment 5 Fedora Update System 2013-10-22 07:32:57 UTC 
createrepo-0.10-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/createrepo-0.10-1.fc19
Comment 6 Fedora Update System 2013-10-30 01:54:13 UTC 
createrepo-0.10-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.