Created attachment 805258 [details] formula Description of problem: GRE manifests write-only behaviour for certain rule features. It has specific UI controls for calls on global variables, formulas, freeform DRL etc., however after saving and reopening the rule, the controls look different and prevent editing affected parts of the rule. Version-Release number of selected component (if applicable): ER3 How reproducible: - Steps to Reproduce: 1. add java.util.ArrayList to project imports 2. define global variable of type java.util.ArrayList 3. open any Guided Rule, import ArrayList 4. add to RHS: - "Call method on <globa_list>", call clear() - "Append <bound variable> to list: <global_list>" - "Modify <bound variable>", set a string field value to "Hello " + "World!" 5. save, close, reopen Actual results: Global calls broken, cannot change the original values. Formula input field changed to literal value input. Expected results: After reopening the rule, guided editor should provide exactly the same controls that the user added before closing the editor. Additional info: See attached screenshots for illustration.
Created attachment 805259 [details] global list before reopen
Created attachment 805261 [details] global list after reopen
Created attachment 807478 [details] rule from bigapp that cannot be opened in the guided rule editor
We encountered several more examples of rules, that can be written in guided rule editor, but when saved and closed, the saved rule can no longer be opened in the editor - the UI shows 'loading' animation indefinitely. The attached rules are currently part of BigApp demo application and can be created by assembling LHS in the editor and then pasting the RHS as freeform DRL. See the rule atatched in comment 3.
Changing severity to match the new scope.
Toni... more tests :(
Ok, unit tests for this done. Passing this to Mario.
I fixed those unit tests, but apparently there is still something that needs to be tuned on the client side. Reassigning this back to Toni.
Client side was ok. Refactored one old test with corrupted data. Back to Mario for further fixing.
Fixed by https://github.com/droolsjbpm/drools/commit/3a0db6253
The problem still persists with the rule in comment 3 (steps to reproduce are described in comment 4). When the rule is clicked in the project explorer, the GRE is not loaded - the editor panel remains empty. See screenshot. 2 things deserve attention: 1) The rule attached is one of the rules used in jboss-bpm-example (Big App) so its important to fix this 2) There should be some feedback given to the user when the rule cannot be loaded into GRE completely (as for example happens in other rules, which are present in the Big App - for more details see Bug 1043395)
One more test https://github.com/droolsjbpm/drools/commit/b106e59ca
Fixed by https://github.com/droolsjbpm/drools/commit/cb58f14e06dddf3b82e839d0a800303f8e65f70d
Mostly fixed. Formula is reloaded as literal value only if it starts with String literal (like "Hello, " + "world!"). Calls on globals are reloaded correctly.