Bug 1013777 - [Eng] (6.4.0) LargeMessages eventually left unattended after failures, making org.hornetq.tests.integration.cluster.failover.BackupSyncLargeMessageTest::testDeleteLargeMessages to intermittently fail
Summary: [Eng] (6.4.0) LargeMessages eventually left unattended after failures, making...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: HornetQ
Version: 6.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: DR1
: EAP 6.4.0
Assignee: Clebert Suconic
QA Contact: Martin Svehla
URL:
Whiteboard:
Depends On: 1016141
Blocks: 1132168 1132185
TreeView+ depends on / blocked
 
Reported: 2013-09-30 18:25 UTC by Clebert Suconic
Modified: 2023-09-14 01:51 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
: 1132185 (view as bug list)
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Clebert Suconic 2013-09-30 18:25:36 UTC
Description of problem:

Large messages not being deleted after failover on BackupSyncLargeMessageTest

In a race condition, large message's journal record could be deleted before the file itself. You could eventually miss the delete command on replication and you won't have how to remove the files unless done manually.

The cost / risk for this is small as the only thing happening is a file that's not deleted after failover on replicated state.

The file can be removed manually after some time easily.

Version-Release number of selected component (if applicable):


How reproducible:

On in 100

Steps to Reproduce:
1. Add a loop method on BackupSyncLargeMessageTest
   @Test
   public void testLoop() throws Exception
   {
      for (int i = 0; i < 1000; i++)
      {
         System.out.println("#test " + i);
         testDeleteLargeMessages();
         tearDown();
         setUp();
      }
   }


2. Run the testLoop and watch it fail.


Actual results:
The test is failing.

Expected results:
The test shouldn't fail even after 1000 iterations


Additional info:

Comment 1 Martin Svehla 2013-10-17 13:13:53 UTC
I added suggested test to BackupSyncLargeMessageTest, but it still fails after some time in 2.3.9 with

java.lang.AssertionError: we really ought to delete these after delivery expected:<10> but was:<11>

Comment 3 Clebert Suconic 2013-10-17 13:20:24 UTC
We have seen failures on this test on our runs... We could keep it to next version.. I investigated and the only scenario we could get was a test issue...


Lets postpone this to next release?

Comment 4 Martin Svehla 2013-10-17 13:35:49 UTC
Agreed, this is not functional issue, so we can postpone.

(Setting qa nack for now to indicate we're ok with not having this in 6.2.0, I'll ack it later when we have some timeline for fix.)

Comment 6 Andy Taylor 2014-07-23 12:57:20 UTC
im working on this

Comment 7 Clebert Suconic 2014-08-04 19:37:19 UTC
https://github.com/hornetq/hornetq/pull/1755

Comment 8 Kabir Khan 2014-08-24 10:59:30 UTC
Appears to be fixed by HQ upgrade to 2.3.21 https://bugzilla.redhat.com/show_bug.cgi?id=1132168. Setting to MODIFIED.

Comment 12 Red Hat Bugzilla 2023-09-14 01:51:22 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.