Created attachment 805764 [details] Use macros to install systemd service units Description of problem: resiprocate enables two services by default: repro.service and resiprocate-turn-server.service They must be installed, but not enabled by default, see: https://fedoraproject.org/wiki/Starting_services_by_default https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Macroized_scriptlets_.28Fedora_18.2B.29 Version-Release number of selected component (if applicable): resiprocate-1.8.11-3.fc21 How reproducible: Install and check the services Steps to Reproduce: 1. yum install resiprocate-repro resiprocate-turn-server. 2. systemctl status repro.service resiprocate-turn-server.service Actual results: Services enabled Expected results: Services installed but disabled Additional info: https://fedoraproject.org/wiki/Starting_services_by_default https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Macroized_scriptlets_.28Fedora_18.2B.29
Any news? If you wish, I can help you as comaintainer.
We are just about to release 1.9.0 upstream I did some work on the spec file in the upstream repository just the other day, would you have a moment to review it and propose any final changes? If you ignore the changelog entries, everything else is identical to the spec file in Fedora Git https://svn.resiprocate.org/viewsvn/resiprocate/main/resiprocate.spec.in?view=markup
(In reply to Daniel Pocock from comment #2) > We are just about to release 1.9.0 upstream > > I did some work on the spec file in the upstream repository just the other > day, would you have a moment to review it and propose any final changes? If > you ignore the changelog entries, everything else is identical to the spec > file in Fedora Git > > https://svn.resiprocate.org/viewsvn/resiprocate/main/resiprocate.spec. > in?view=markup That's great. I have made a patch against the svn using the systemd macros and I also have used %{_sharedstatedir} instead of %{_localstatedir}/lib Thank you! :)
Created attachment 860221 [details] Patch against the svn version
Thanks for these contributions I notice your two patches have different variations of the systemd macro stuff Should I just use https://bugzilla.redhat.com/attachment.cgi?id=860221 ?
(In reply to Daniel Pocock from comment #5) > Thanks for these contributions > > I notice your two patches have different variations of the systemd macro > stuff > > Should I just use > https://bugzilla.redhat.com/attachment.cgi?id=860221 ? Yes, use that one.
Thanks for that, it is now committed to SVN and cherry picked to the 1.9 release branch we are working on. Can you let me know which Fedora versions you tried it on? If I understand correctly, I can push the v1.9.0 package to Fedora 19, 20 and rawhide when it is released? Or should it just go into rawhide and leave existing F19 and F20 users with 1.8.x?
I'm trying repro and return in F20. About the 1.9.0 release, I'm not sure about releasing to F19 and F20, if it is going to break existing setups, I'm against it. Probably it's better to release only to rawhide-F21
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.