Bug 10143 - RPM_OPT_FLAGS not honored in zip-2.3-4
Summary: RPM_OPT_FLAGS not honored in zip-2.3-4
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Raw Hide
Classification: Retired
Component: zip (Show other bugs)
(Show other bugs)
Version: 1.0
Hardware: All Linux
medium
low
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2000-03-13 12:58 UTC by Moritz Barsnick
Modified: 2014-03-17 02:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2000-03-13 23:03:53 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description Moritz Barsnick 2000-03-13 12:58:16 UTC
In the spec file of zip-2.3-4, the %build section is:
> make -f unix/Makefile prefix=/usr "RPM_OPT_FLAGS=$RPM_OPT_FLAGS"
generic_gcc

The definition of RPM_OPT_FLAGS is of absolutely no use, as that string is
totally unknown in the package (and the patch).

I suggest using $LOCAL_ZIP ($(LOCAL_ZIP) in the unix/Makefile), as it is
otherwise unused, and as redefining CFLAGS conflicts with some other flags
(-I. -DUNIX would have to be added). Unless of course, the "-O2" of the
original CFLAGS aren't overridden by the RPM_OPT_FLAGS, which I
unfortunately couldn't read out of the gcc documentation.

> make -f unix/Makefile prefix=/usr LOCAL_ZIP="$RPM_OPT_FLAGS" generic_gcc
or
> make -f unix/Makefile prefix=/usr CFLAGS="$RPM_OPT_FLAGS -I. -DUNIX"
generic_gcc

While you're at it, make "prefix=/usr" to "prefix=%{prefix}" (and replace
it in all the other places) - it _is_ defined in the spec file's header
already.

Comment 1 Bill Nottingham 2000-03-13 16:44:59 UTC
Fixed in zip-2.3-5.


Note You need to log in before you can comment on or make changes to this bug.